New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Japanese translation in media library #7226
add Japanese translation in media library #7226
Conversation
Signed-off-by: eggpogg <eggpogg.t@gmail.com>
@@ -203,6 +204,7 @@ | |||
"notification.error.layout": "レイアウトを復旧できませんでした", | |||
"notification.form.error.fields": "フォームに同じエラーがあります", | |||
"notification.form.success.fields": "保存されました", | |||
"notification.link-copied": "クリップボードにリンクをコピーしました", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to google translate... This traduction says 'I copied the link..' Can you remove all first person from your translations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review.
This sentence does not include the wording of the first person.
This is a common Japanese phrase.
Other sentences are the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I understand!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: eggpogg <eggpogg.t@gmail.com> Co-authored-by: cyril lopez <cyril.lpz@gmail.com> Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Description of what you did:
Updated Japanese translation file in strapi-admin and strapi-plugin-upload.
test