Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Japanese translation in media library #7226

Merged

Conversation

eggpogg
Copy link
Contributor

@eggpogg eggpogg commented Jul 28, 2020

Description of what you did:

Updated Japanese translation file in strapi-admin and strapi-plugin-upload.

test

❯ yarn test:front
yarn run v1.22.4
---
Test Suites: 153 passed, 153 total
Tests:       680 passed, 680 total
Snapshots:   8 passed, 8 total
Time:        39.779 s
Ran all test suites.
✨  Done in 43.45s.

@lauriejim lauriejim requested a review from soupette July 28, 2020 09:07
@@ -203,6 +204,7 @@
"notification.error.layout": "レイアウトを復旧できませんでした",
"notification.form.error.fields": "フォームに同じエラーがあります",
"notification.form.success.fields": "保存されました",
"notification.link-copied": "クリップボードにリンクをコピーしました",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to google translate... This traduction says 'I copied the link..' Can you remove all first person from your translations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soupette

Thank you for the review.

This sentence does not include the wording of the first person.
This is a common Japanese phrase.

Other sentences are the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I understand!

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette added source: core:admin Source is core/admin package source: core:upload Source is core/upload package issue: enhancement Issue suggesting an enhancement to an existing feature and removed source: core:admin Source is core/admin package labels Jul 28, 2020
@soupette soupette added this to the 3.1.2 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:upload Source is core/upload package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants