Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7189 #7228

Merged
merged 1 commit into from Jul 28, 2020
Merged

Fixes #7189 #7228

merged 1 commit into from Jul 28, 2020

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril.lpz@gmail.com

Description of what you did:

This PR fixes #7189

Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette added source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #7228 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7228      +/-   ##
==========================================
- Coverage   26.17%   26.17%   -0.01%     
==========================================
  Files        1130     1130              
  Lines       15411    15413       +2     
  Branches     2438     2439       +1     
==========================================
  Hits         4034     4034              
- Misses       9559     9560       +1     
- Partials     1818     1819       +1     
Flag Coverage Δ
#front 18.27% <0.00%> (-0.01%) ⬇️
#unit 52.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...manager/admin/src/components/FilterPicker/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da338f9...61412eb. Read the comment docs.

@alexandrebodin alexandrebodin added this to the 3.1.2 milestone Jul 28, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model using component fails with error since update
2 participants