Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/parameters typos #7238

Merged
merged 4 commits into from Jul 29, 2020

Conversation

sebacampos
Copy link
Contributor

Description of what you did:

Fixed documentation 'complexE' typos

@alexandrebodin
Copy link
Member

Hi @sebacampos sorry but your PR was started from master and is on documentation it contains too many unwanted commits. Can you please clean it :)

@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Jul 29, 2020
@sebacampos
Copy link
Contributor Author

sebacampos commented Jul 29, 2020

Done @alexandrebodin ✅ Sorry about that. I had the feeling it was wrong when saw too many files showing changes... but I left it like that since I just followed the contributing guide step by step to the letter, and it says:

Fork the repository and create your branch from master.

Maybe would be nice to point out that for documentation fixes, branch should be created from documentation branch, and not from master, in order to avoid others repeat my misunderstanding in the future... Something like this:

Fork the repository and create your branch from master. (If it's a documentation fix, create your branch from documentation branch, not master)

Let me know what you think, and will add a commit with that fix on the CONTRIBUTING.md

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #7238 into documentation will increase coverage by 7.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           documentation    #7238      +/-   ##
=================================================
+ Coverage          19.14%   26.17%   +7.03%     
=================================================
  Files                855     1130     +275     
  Lines              11933    15414    +3481     
  Branches            1898     2439     +541     
=================================================
+ Hits                2284     4034    +1750     
- Misses              8100     9561    +1461     
- Partials            1549     1819     +270     
Flag Coverage Δ
#front 18.27% <ø> (+3.78%) ⬆️
#unit 52.96% <ø> (+13.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...i-admin/admin/src/containers/SettingsPage/index.js 0.00% <0.00%> (-66.67%) ⬇️
...trapi-admin/admin/src/containers/LeftMenu/index.js 5.00% <0.00%> (-61.67%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
...in/admin/src/containers/Webhooks/ListView/index.js 0.00% <0.00%> (-42.11%) ⬇️
...in/admin/src/containers/Webhooks/EditView/index.js 0.00% <0.00%> (-38.40%) ⬇️
packages/strapi/lib/services/metrics/index.js 65.00% <0.00%> (-35.00%) ⬇️
...admin/admin/src/components/ContainerFluid/index.js 66.66% <0.00%> (-33.34%) ⬇️
...s/strapi-admin/admin/src/containers/Admin/index.js 63.82% <0.00%> (-15.66%) ⬇️
... and 645 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf278ae...622f273. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! 💯 Hope you like this new feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants