New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/parameters typos #7238
Docs/parameters typos #7238
Conversation
Hi @sebacampos sorry but your PR was started from master and is on documentation it contains too many unwanted commits. Can you please clean it :) |
update fork with latest strapi release
…into docs/parameters-typos
Done @alexandrebodin ✅ Sorry about that. I had the feeling it was wrong when saw too many files showing changes... but I left it like that since I just followed the contributing guide step by step to the letter, and it says:
Maybe would be nice to point out that for documentation fixes, branch should be created from documentation branch, and not from master, in order to avoid others repeat my misunderstanding in the future... Something like this:
Let me know what you think, and will add a commit with that fix on the CONTRIBUTING.md |
Codecov Report
@@ Coverage Diff @@
## documentation #7238 +/- ##
=================================================
+ Coverage 19.14% 26.17% +7.03%
=================================================
Files 855 1130 +275
Lines 11933 15414 +3481
Branches 1898 2439 +541
=================================================
+ Hits 2284 4034 +1750
- Misses 8100 9561 +1461
- Partials 1549 1819 +270
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ! 💯 Hope you like this new feature :)
* fix 'complexE' typos * fix 'complexE' typos Co-authored-by: scampos <sebastian@synergiar.com> Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Description of what you did:
Fixed documentation 'complexE' typos