Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information about the parser middleware configuration #7253

Merged
merged 2 commits into from Jul 30, 2020

Conversation

derrickmehaffy
Copy link
Member

Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com

Description of what you did:

In a convo on slack, noticed we were missing some of the useful options for the parser middleware from koa-body added them and a link to the package in the docs.

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@derrickmehaffy derrickmehaffy added the source: docs Documentation changes label Jul 29, 2020
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #7253 into documentation will increase coverage by 7.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           documentation    #7253      +/-   ##
=================================================
+ Coverage          19.14%   26.17%   +7.03%     
=================================================
  Files                855     1130     +275     
  Lines              11933    15414    +3481     
  Branches            1898     2439     +541     
=================================================
+ Hits                2284     4034    +1750     
- Misses              8100     9561    +1461     
- Partials            1549     1819     +270     
Flag Coverage Δ
#front 18.27% <ø> (+3.78%) ⬆️
#unit 52.96% <ø> (+13.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...i-admin/admin/src/containers/SettingsPage/index.js 0.00% <0.00%> (-66.67%) ⬇️
...trapi-admin/admin/src/containers/LeftMenu/index.js 5.00% <0.00%> (-61.67%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
...in/admin/src/containers/Webhooks/ListView/index.js 0.00% <0.00%> (-42.11%) ⬇️
...in/admin/src/containers/Webhooks/EditView/index.js 0.00% <0.00%> (-38.40%) ⬇️
packages/strapi/lib/services/metrics/index.js 65.00% <0.00%> (-35.00%) ⬇️
...admin/admin/src/components/ContainerFluid/index.js 66.66% <0.00%> (-33.34%) ⬇️
...s/strapi-admin/admin/src/containers/Admin/index.js 63.82% <0.00%> (-15.66%) ⬇️
... and 645 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba02fe...ddeb938. Read the comment docs.

@alexandrebodin alexandrebodin added this to the 3.1.3 milestone Jul 30, 2020
@alexandrebodin alexandrebodin added the issue: enhancement Issue suggesting an enhancement to an existing feature label Jul 30, 2020
@alexandrebodin alexandrebodin merged commit 28b66d2 into documentation Jul 30, 2020
@alexandrebodin alexandrebodin deleted the docs/middleware branch July 30, 2020 07:49
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
…i#7253)

* Add more information about the parser middleware configuration

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>

* fix integer case

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants