Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gender Equality #7263

Merged
merged 1 commit into from Aug 3, 2020
Merged

Gender Equality #7263

merged 1 commit into from Aug 3, 2020

Conversation

votemike
Copy link
Contributor

Description of what you did:

Changed words to be gender neutral.

@cat-michael-gwynne
Gender Equality
e6d3cc7 
Signed-off-by: Michael Gwynne <michael.gwynne@checkatrade.com>
russellf9
russellf9 approved these changes Jul 30, 2020
View reviewed changes
Copy link

@russellf9 russellf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting documentation from Google:

Pronouns

@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited

Codecov Report

Merging #7263 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7263      +/-   ##
==========================================
- Coverage   26.17%   26.17%   -0.01%     
==========================================
  Files        1130     1130              
  Lines       15413    15414       +1     
  Branches     2439     2439              
==========================================
  Hits         4034     4034              
- Misses       9560     9561       +1     
  Partials     1819     1819
Flag Coverage Δ
#front 18.27% <0.00%> (-0.01%) ⬇️
#unit 52.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...min/src/containers/Onboarding/StaticLinks/index.js 0.00% <0.00%> (ø)
...admin/admin/src/containers/Users/EditPage/index.js 11.76% <ø> (ø)
...ntent-manager/admin/src/components/Inputs/index.js 0.00% <0.00%> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836b49f...e6d3cc7. Read the comment docs.

@votemike
Copy link
Contributor Author

Not sure how to make the 2 failing checks pass for this PR.

@russellf9
Copy link

Just a wild thought - could it be a rounding issue?

@alexandrebodin alexandrebodin added this to the 3.1.4 milestone Aug 3, 2020
@alexandrebodin alexandrebodin added source: core:admin Source is core/admin package issue: enhancement Issue suggesting an enhancement to an existing feature labels Aug 3, 2020
alexandrebodin
alexandrebodin approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 81a4509 into strapi:master Aug 3, 2020
@votemike votemike deleted the gender-equality branch August 4, 2020 14:37
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellf9 russellf9 russellf9 approved these changes

@alexandrebodin alexandrebodin alexandrebodin approved these changes

@maevalienard maevalienard Awaiting requested review from maevalienard

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Milestone
3.1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@votemike @russellf9 @alexandrebodin @cat-michael-gwynne