Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #7301 #7312

Merged
merged 1 commit into from Aug 12, 2020
Merged

Fixes #7301 #7312

merged 1 commit into from Aug 12, 2020

Conversation

soupette
Copy link
Contributor

@soupette soupette commented Aug 4, 2020

Signed-off-by: soupette cyril.lpz@gmail.com

Description of what you did:

This PR fixes #7301

@soupette
Fixes #7301
f34c947 
Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette added source: core:content-type-builder Source is core/content-type-builder package issue: bug Issue reporting a bug labels Aug 4, 2020
@soupette soupette added this to the 3.1.4 milestone Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020 •
edited

Codecov Report

Merging #7312 into master will increase coverage by 0.04%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7312      +/-   ##
==========================================
+ Coverage   26.17%   26.21%   +0.04%     
==========================================
  Files        1130     1131       +1     
  Lines       15415    15441      +26     
  Branches     2439     2444       +5     
==========================================
+ Hits         4035     4048      +13     
- Misses       9561     9572      +11     
- Partials     1819     1821       +2
Flag Coverage Δ
#front 18.25% <0.00%> (-0.02%) ⬇️
#unit 53.14% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/strapi-admin/admin/src/containers/Admin/index.js 63.82% <ø> (ø)
...admin/admin/src/containers/Roles/EditPage/index.js 2.77% <0.00%> (-0.80%) ⬇️
...admin/admin/src/containers/Roles/ListPage/index.js 0.00% <0.00%> (ø)
...ype-builder/admin/src/containers/ListView/index.js 0.00% <0.00%> (ø)
packages/strapi-admin/services/metrics.js 100.00% <100.00%> (ø)
packages/strapi-admin/services/role.js 94.11% <100.00%> (+0.14%) ⬆️
packages/strapi-admin/services/user.js 82.56% <100.00%> (+0.66%) ⬆️
packages/strapi/lib/services/metrics/sender.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8bb45d...f34c947. Read the comment docs.

HichamELBSI
HichamELBSI approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette removed this from the 3.1.4 milestone Aug 11, 2020
@alexandrebodin alexandrebodin added this to the 3.1.4 milestone Aug 12, 2020
@alexandrebodin alexandrebodin merged commit 99dfd24 into master Aug 12, 2020
@alexandrebodin alexandrebodin deleted the fix/7301 branch August 12, 2020 10:15
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
@soupette @onepointconsulting
Fixes strapi#7301 (strapi#7312)
87c0838 
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HichamELBSI HichamELBSI HichamELBSI approved these changes

Assignees

@HichamELBSI HichamELBSI

Labels
issue: bug Issue reporting a bug source: core:content-type-builder Source is core/content-type-builder package
Projects
None yet
Milestone
3.1.4
Development

Successfully merging this pull request may close these issues.

A 'configure the view' button doesn't work correctly in Content-Types Builder.
3 participants
@soupette @HichamELBSI @alexandrebodin