Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/6641 #7337

Merged
merged 8 commits into from Aug 12, 2020
Merged

Fix/6641 #7337

merged 8 commits into from Aug 12, 2020

Conversation

laurentcomte
Copy link
Contributor

fix #6641
PR is ready to be merged

added prop "autoFocus" to HeaderSearch component (default prop value : "false")
set this prop to "true" for HeaderSearch in HomePageSettings
Now, when the "Media Library" page is loaded, the input search has the focus.
After some text is entered and the page has been refreshed, the input search has still the focus.

laurentcomte and others added 7 commits August 5, 2020 14:50
while typing

Signed-off-by: Laurent Comte <laurent.comte@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #7337 into master will increase coverage by 0.05%.
The diff coverage is 48.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7337      +/-   ##
==========================================
+ Coverage   26.17%   26.22%   +0.05%     
==========================================
  Files        1130     1131       +1     
  Lines       15415    15433      +18     
  Branches     2439     2443       +4     
==========================================
+ Hits         4035     4048      +13     
- Misses       9561     9565       +4     
- Partials     1819     1820       +1     
Flag Coverage Δ
#front 18.26% <0.00%> (-0.01%) ⬇️
#unit 53.14% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/strapi-admin/admin/src/containers/Admin/index.js 63.82% <ø> (ø)
...admin/admin/src/containers/Roles/EditPage/index.js 2.77% <0.00%> (-0.80%) ⬇️
...admin/admin/src/containers/Roles/ListPage/index.js 0.00% <0.00%> (ø)
...iners/HomePage/HomePageContent/HomePageSettings.js 0.00% <ø> (ø)
...ermissions/admin/src/components/PopUpForm/index.js 0.00% <0.00%> (ø)
packages/strapi-admin/services/metrics.js 100.00% <100.00%> (ø)
packages/strapi-admin/services/role.js 94.11% <100.00%> (+0.14%) ⬆️
packages/strapi-admin/services/user.js 82.56% <100.00%> (+0.66%) ⬆️
packages/strapi/lib/services/metrics/sender.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7113f7f...c42c4d9. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette added source: core:admin Source is core/admin package source: core:upload Source is core/upload package issue: bug Issue reporting a bug and removed source: core:admin Source is core/admin package labels Aug 11, 2020
@soupette soupette modified the milestone: 3.1.4 Aug 11, 2020
@alexandrebodin alexandrebodin added this to the 3.1.4 milestone Aug 12, 2020
@alexandrebodin alexandrebodin merged commit 086677b into strapi:master Aug 12, 2020
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
* Fix "Search for an asset" on Media Library loses focus
while typing

Signed-off-by: Laurent Comte <laurent.comte@gmail.com>

* Update the provider loggin doc + display absolute redirect uri in front

Signed-off-by: Pierre Noël <petersg83@gmail.com>

* update grant + doc twitter

Signed-off-by: Pierre Noël <petersg83@gmail.com>

* refacto

Signed-off-by: Pierre Noël <petersg83@gmail.com>

* replace .fr by .com

Signed-off-by: Pierre Noël <petersg83@gmail.com>

* move a tip

Signed-off-by: Pierre Noël <petersg83@gmail.com>

* Specify that only grant providers are supported

Signed-off-by: Pierre Noël <petersg83@gmail.com>

Co-authored-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:upload Source is core/upload package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Search for an asset" on Media Library loses focus while typing
4 participants