Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WYSIWYG bugs #7370

Merged
merged 2 commits into from Aug 12, 2020
Merged

Fix WYSIWYG bugs #7370

merged 2 commits into from Aug 12, 2020

Conversation

soupette
Copy link
Contributor

@soupette soupette commented Aug 7, 2020 •
edited

@soupette
Fixes #7314
44a437c 
Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette added source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Aug 7, 2020
@soupette soupette added this to the 3.1.4 milestone Aug 7, 2020
@soupette
Fixes #4300
6ec001d 
Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette changed the title Fixes #7314 Fix WYSIWYG bugs Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 7, 2020 •
edited

Codecov Report

Merging #7370 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7370      +/-   ##
==========================================
- Coverage   26.22%   26.22%   -0.01%     
==========================================
  Files        1131     1131              
  Lines       15433    15435       +2     
  Branches     2443     2443              
==========================================
  Hits         4048     4048              
- Misses       9565     9567       +2     
  Partials     1820     1820
Flag Coverage Δ
#front 18.26% <0.00%> (-0.01%) ⬇️
#unit 53.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-manager/admin/src/components/Wysiwyg/constants.js 0.00% <ø> (ø)
...nt-manager/admin/src/components/Wysiwyg/helpers.js 0.00% <0.00%> (ø)
...tent-manager/admin/src/components/Wysiwyg/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de10a34...6ec001d. Read the comment docs.

HichamELBSI
HichamELBSI approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette removed this from the 3.1.4 milestone Aug 11, 2020
@alexandrebodin alexandrebodin added this to the 3.1.4 milestone Aug 12, 2020
@alexandrebodin alexandrebodin merged commit f6f5095 into master Aug 12, 2020
@alexandrebodin alexandrebodin deleted the fix/7314 branch August 12, 2020 10:07
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
@soupette @onepointconsulting
Fix WYSIWYG bugs (strapi#7370)
e387973 
* Fixes strapi#7314

Signed-off-by: soupette <cyril.lpz@gmail.com>

* Fixes strapi#4300

Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HichamELBSI HichamELBSI HichamELBSI approved these changes

Assignees

@lauriejim lauriejim

@HichamELBSI HichamELBSI

Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Milestone
3.1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@soupette @HichamELBSI @lauriejim @alexandrebodin