Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strapi-provider-upload-local readme #7373

Merged
merged 3 commits into from Aug 10, 2020
Merged

Fix strapi-provider-upload-local readme #7373

merged 3 commits into from Aug 10, 2020

Conversation

remidej
Copy link
Contributor

@remidej remidej commented Aug 7, 2020

Description of what you did:

Fixed the Readme docs of the strapi-provider-upload-local package.

They talked about Cloudinary, probably because of a copy and paste mistake.

I also wrote that the sizeLimit config value should be specified in bytes and not KB, since it seems to rely on File.size

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #7373 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7373   +/-   ##
=======================================
  Coverage   26.22%   26.22%           
=======================================
  Files        1131     1131           
  Lines       15433    15433           
  Branches     2443     2443           
=======================================
  Hits         4048     4048           
  Misses       9565     9565           
  Partials     1820     1820           
Flag Coverage Δ
#front 18.26% <ø> (ø)
#unit 53.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8dc074...5fcbcaa. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.1.4 milestone Aug 10, 2020
@alexandrebodin alexandrebodin added issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes labels Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants