Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic GraphQL Plugin information #7385

Merged
merged 6 commits into from Aug 17, 2020
Merged

Conversation

ScottAgirs
Copy link
Contributor

Description of what you did:

If merged this will update plugin description and add a link to Strapi GraphQL docs in the Strapi Plugin README.md file.

Signed-off-by: ScottAgirs <scott@ijs.to>
Signed-off-by: ScottAgirs <scott@ijs.to>
@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #7385 into master will decrease coverage by 0.01%.
The diff coverage is 2.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7385      +/-   ##
==========================================
- Coverage   26.23%   26.21%   -0.02%     
==========================================
  Files        1131     1131              
  Lines       15431    15440       +9     
  Branches     2442     2438       -4     
==========================================
  Hits         4048     4048              
- Misses       9564     9576      +12     
+ Partials     1819     1816       -3     
Flag Coverage Δ
#front 18.25% <2.38%> (-0.02%) ⬇️
#unit 53.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pi-admin/admin/src/components/GlobalStyle/index.js 0.00% <ø> (ø)
...nt-manager/admin/src/components/CustomTable/Row.js 0.00% <ø> (ø)
.../admin/src/components/InputJSONWithErrors/index.js 0.00% <0.00%> (ø)
...ent-manager/admin/src/components/InputUID/index.js 0.00% <0.00%> (ø)
...ponents/MediaPreviewList/StyledMediaPreviewList.js 0.00% <ø> (ø)
...-manager/admin/src/components/Wysiwyg/constants.js 0.00% <ø> (ø)
...nt-manager/admin/src/components/Wysiwyg/helpers.js 0.00% <0.00%> (ø)
...tent-manager/admin/src/components/Wysiwyg/index.js 0.00% <0.00%> (ø)
...er/admin/src/components/WysiwygWithErrors/index.js 0.00% <0.00%> (ø)
...uilder/admin/src/components/ComponentCard/index.js 0.00% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 331b738...bdf3b03. Read the comment docs.

lauriejim
lauriejim previously approved these changes Aug 10, 2020
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Strapi GraphQL

This plugin will add GraphQL functionality to your app.
By default it will provide you with most CRUD methods exposed in Strapi REST API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default it will provide you with most of the CRUD methods exposed in the Strapi REST API.

Minor tweak to the grammer 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: ScottAgirs <scott@ijs.to>
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: plugin:graphql Source is plugin/graphql package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants