Show error.message || error on failed command #7388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some exceptions, like module inclusion errors, don't generate nice Error objects with message defined. This causes hard-to-debug failures. When encountering an error with no message, show the whole Error object. Signed-off-by: Jason Prado <jason.prado@gmail.com>
jasonprado
force-pushed
the
command_error_stack
branch
from
46f45e7
to
9584116
Compare
Codecov Report
@@ Coverage Diff @@
## master #7388 +/- ##
=======================================
Coverage 26.22% 26.22%
=======================================
Files 1131 1131
Lines 15433 15433
Branches 2443 2443
=======================================
Hits 4048 4048
Misses 9565 9565
Partials 1820 1820
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
alexandrebodin
added
source: cli
gilfernandes
pushed a commit
to onepointconsulting/strapi
that referenced
this pull request
Aug 13, 2020
Some exceptions, like module inclusion errors, don't generate nice Error objects with message defined. This causes hard-to-debug failures. When encountering an error with no message, show the whole Error object. Signed-off-by: Jason Prado <jason.prado@gmail.com> Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com> Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Aug 19, 2020
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some exceptions, like module inclusion errors, don't generate nice
Error objects with message defined. This causes hard-to-debug failures.
When encountering an error with no message, show the whole Error object.
Description of what you did:
In the
strapiexecutable if a subcommand throws an error the driver printserror.message. But some errors don't have amessageand this leads to a bad error message in the console. I printerror.message || errorinstead.