Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating email documentation adding a tip during initial setup to avo… #7413

Merged
merged 1 commit into from Aug 12, 2020
Merged

Updating email documentation adding a tip during initial setup to avo… #7413

merged 1 commit into from Aug 12, 2020

Conversation

juancarlosjr97
Copy link
Contributor

…id issues during strapi creation

Description of what you did:

  • Updated email documentation adding a tip during the Strapi initial setup to avoid issues sending confirmation emails.

@juancarlosjr97
Updating email documentation adding a tip during initial setup to avo…
fca0788 
…id issues during strapi creation

Signed-off-by: Juan Carlos Blanco Delgado <juancarlosjr97@gmail.com>
@derrickmehaffy derrickmehaffy self-requested a review August 10, 2020 22:28
@codecov
Copy link

codecov bot commented Aug 10, 2020 •
edited

Codecov Report

Merging #7413 into documentation will increase coverage by 7.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           documentation    #7413      +/-   ##
=================================================
+ Coverage          19.14%   26.17%   +7.03%     
=================================================
  Files                855     1130     +275     
  Lines              11933    15414    +3481     
  Branches            1898     2439     +541     
=================================================
+ Hits                2284     4034    +1750     
- Misses              8100     9561    +1461     
- Partials            1549     1819     +270
Flag Coverage Δ
#front 18.27% <ø> (+3.78%) ⬆️
#unit 52.96% <ø> (+13.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...i-admin/admin/src/containers/SettingsPage/index.js 0.00% <0.00%> (-66.67%) ⬇️
...trapi-admin/admin/src/containers/LeftMenu/index.js 5.00% <0.00%> (-61.67%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
...in/admin/src/containers/Webhooks/ListView/index.js 0.00% <0.00%> (-42.11%) ⬇️
...in/admin/src/containers/Webhooks/EditView/index.js 0.00% <0.00%> (-38.40%) ⬇️
packages/strapi/lib/services/metrics/index.js 65.00% <0.00%> (-35.00%) ⬇️
...admin/admin/src/components/ContainerFluid/index.js 66.66% <0.00%> (-33.34%) ⬇️
...s/strapi-admin/admin/src/containers/Admin/index.js 63.82% <0.00%> (-15.66%) ⬇️
... and 645 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2e2c1...fca0788. Read the comment docs.

derrickmehaffy
derrickmehaffy approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.1.4 milestone Aug 12, 2020
@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Aug 12, 2020
@alexandrebodin alexandrebodin merged commit 1afbdd6 into strapi:documentation Aug 12, 2020
@juancarlosjr97 juancarlosjr97 mentioned this pull request Aug 13, 2020
Closed
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
@juancarlosjr97 @onepointconsulting
Updating email documentation adding a tip during initial setup to avo…
1ab95ef 
…id issues during strapi creation (strapi#7413)

Signed-off-by: Juan Carlos Blanco Delgado <juancarlosjr97@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrickmehaffy derrickmehaffy derrickmehaffy approved these changes

@lauriejim lauriejim Awaiting requested review from lauriejim

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Milestone
3.1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juancarlosjr97 @derrickmehaffy @alexandrebodin