Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7414 #7416

Merged
merged 2 commits into from Aug 12, 2020
Merged

Fixes #7414 #7416

merged 2 commits into from Aug 12, 2020

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril.lpz@gmail.com

Description of what you did:

This PR fixes the initialisation of the default data structure in the content manager plugin.

Fixes #7414

Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette added source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Aug 11, 2020
@soupette soupette added this to the 3.1.4 milestone Aug 11, 2020
@soupette soupette removed this from the 3.1.4 milestone Aug 11, 2020
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #7416 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7416   +/-   ##
=======================================
  Coverage   26.22%   26.23%           
=======================================
  Files        1131     1131           
  Lines       15433    15431    -2     
  Branches     2443     2442    -1     
=======================================
  Hits         4048     4048           
+ Misses       9565     9564    -1     
+ Partials     1820     1819    -1     
Flag Coverage Δ
#front 18.26% <ø> (+<0.01%) ⬆️
#unit 53.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/containers/EditViewDataManagerProvider/index.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56cc7f...9d06b57. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeatable component won't expand
3 participants