New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find file to edit in all available files #7459
Conversation
4a8a2da
to
ce9ee91
Compare
This resolves strapi#7458 Signed-off-by: Wessel van der Linden <wessel.linden@gmail.com>
ce9ee91
to
7b04d2e
Compare
Codecov Report
@@ Coverage Diff @@
## master #7459 +/- ##
=======================================
Coverage 26.38% 26.38%
=======================================
Files 1131 1131
Lines 15442 15442
Branches 2439 2439
=======================================
Hits 4074 4074
Misses 9559 9559
Partials 1809 1809
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for taking the time to contribute
This resolves strapi#7458 Signed-off-by: Wessel van der Linden <wessel.linden@gmail.com> Co-authored-by: cyril lopez <cyril.lpz@gmail.com> Signed-off-by: Garrett Fritz <garrettfritz@garretts-mbp.home>
If a file is selected, but not loaded in the 'files' array of the state, it can't be found and you will get an error after clicking on the edit icon.
This PR will make sure it will look in both the 'files' and the 'selectedFiles' arrays for the given file id.
This resolves #7458