Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find file to edit in all available files #7459

Merged
merged 2 commits into from Sep 3, 2020

Conversation

wesselvanderlinden
Copy link
Contributor

If a file is selected, but not loaded in the 'files' array of the state, it can't be found and you will get an error after clicking on the edit icon.

This PR will make sure it will look in both the 'files' and the 'selectedFiles' arrays for the given file id.

This resolves #7458

This resolves strapi#7458

Signed-off-by: Wessel van der Linden <wessel.linden@gmail.com>
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #7459 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7459   +/-   ##
=======================================
  Coverage   26.38%   26.38%           
=======================================
  Files        1131     1131           
  Lines       15442    15442           
  Branches     2439     2439           
=======================================
  Hits         4074     4074           
  Misses       9559     9559           
  Partials     1809     1809           
Flag Coverage Δ
#front 18.25% <100.00%> (ø)
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/containers/InputModalStepperProvider/reducer.js 68.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee79e2...765107d. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for taking the time to contribute

@alexandrebodin alexandrebodin added this to the 3.1.5 milestone Sep 3, 2020
@alexandrebodin alexandrebodin added source: core:upload Source is core/upload package issue: bug Issue reporting a bug labels Sep 3, 2020
@alexandrebodin alexandrebodin merged commit 9610f4c into strapi:master Sep 3, 2020
gfritzdev pushed a commit to gfritzdev/strapi that referenced this pull request Sep 7, 2020
This resolves strapi#7458

Signed-off-by: Wessel van der Linden <wessel.linden@gmail.com>

Co-authored-by: cyril lopez <cyril.lpz@gmail.com>
Signed-off-by: Garrett Fritz <garrettfritz@garretts-mbp.home>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:upload Source is core/upload package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't edit an asset from SELECT section when it's not loaded in the BROWSE section
3 participants