Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users and Permissions in Settings menu #7467

Merged
merged 42 commits into from Aug 31, 2020

Conversation

HichamELBSI
Copy link
Contributor

@HichamELBSI HichamELBSI commented Aug 14, 2020

Signed-off-by: HichamELBSI elabbassih@gmail.com

Description of what you did:

  • Create and edit a role in User & permissions settings
  • Remove old plugin files

Closes #7584
Closes #2992

HichamELBSI and others added 25 commits August 3, 2020 17:11
Signed-off-by: HichamELBSI <elabbassih@gmail.com>
Signed-off-by: HichamELBSI <elabbassih@gmail.com>
[WIP] Init Users & Permissions settings section
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: HichamELBSI <elabbassih@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Move users-permissions plugin views to settings
@HichamELBSI HichamELBSI force-pushed the users-permissions/create-new-role branch 5 times, most recently from d28dbea to 9009a97 Compare August 14, 2020 10:02
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #7467 into master will increase coverage by 0.86%.
The diff coverage is 21.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7467      +/-   ##
==========================================
+ Coverage   26.37%   27.23%   +0.86%     
==========================================
  Files        1131     1163      +32     
  Lines       15449    15532      +83     
  Branches     2441     2411      -30     
==========================================
+ Hits         4074     4230     +156     
+ Misses       9564     9534      -30     
+ Partials     1811     1768      -43     
Flag Coverage Δ
#front 19.41% <21.13%> (+1.17%) ⬆️
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ingsPermissions/PermissionRow/SubCategory/index.js 0.00% <0.00%> (ø)
...dmin/src/containers/SettingsPage/StyledLeftMenu.js 100.00% <ø> (ø)
...s/admin/src/components/BaselineAlignement/index.js 0.00% <0.00%> (ø)
...ers-permissions/admin/src/components/Bloc/index.js 0.00% <0.00%> (ø)
...ions/admin/src/components/BoundRoute/Components.js 0.00% <ø> (ø)
...rmissions/admin/src/components/BoundRoute/index.js 0.00% <0.00%> (ø)
...sions/admin/src/components/ContainerFluid/index.js 0.00% <0.00%> (ø)
...permissions/admin/src/components/FormBloc/index.js 0.00% <0.00%> (ø)
...ermissions/admin/src/components/IntlInput/index.js 0.00% <0.00%> (ø)
...dmin/src/components/ListBaselineAlignment/index.js 0.00% <0.00%> (ø)
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64de3a2...16261bb. Read the comment docs.

Copy link
Contributor Author

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HichamELBSI
Copy link
Contributor Author

HichamELBSI commented Aug 27, 2020

@soupette LGTM

Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette force-pushed the users-permissions/create-new-role branch from 8a4263b to 3c7ea06 Compare August 28, 2020 09:38
co-authored elabbassih@gmail.com

Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
const plugins = await strapi.plugins[
'users-permissions'
].services.userspermissions.getPlugins(lang);
// @alexandrebodin I am removing this as it is not needed anymore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are not using the information anymore you can delete this yeas. You can also cleanup the getActions method in the service and remove the withInfo and the information property in the returned data then

Signed-off-by: soupette <cyril.lpz@gmail.com>
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.1.5 milestone Aug 31, 2020
@alexandrebodin alexandrebodin added source: plugin:users-permissions Source is plugin/users-permissions package issue: bug Issue reporting a bug issue: enhancement Issue suggesting an enhancement to an existing feature and removed issue: bug Issue reporting a bug labels Aug 31, 2020
@alexandrebodin alexandrebodin merged commit 77be3ea into master Aug 31, 2020
@alexandrebodin alexandrebodin deleted the users-permissions/create-new-role branch August 31, 2020 13:33
@lauriejim
Copy link
Contributor

This pull request has been mentioned on Strapi Community. There might be relevant details there:

https://forum.strapi.io/t/after-migration-from-3-0-0-to-3-1-6-roles-permissions-link-is-missing-from-admin-menu/289/2

@lauriejim
Copy link
Contributor

This pull request has been mentioned on Strapi Community. There might be relevant details there:

https://forum.strapi.io/t/roles-and-permissions-not-showing-after-clear-installation/500/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: plugin:users-permissions Source is plugin/users-permissions package
Projects
None yet
4 participants