Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LinkedIn auth provider #7490

Merged
merged 3 commits into from Sep 4, 2020
Merged

Add LinkedIn auth provider #7490

merged 3 commits into from Sep 4, 2020

Conversation

abolkog
Copy link
Contributor

@abolkog abolkog commented Aug 16, 2020

Description of what you did:

Added LinkedIn auth provider to support login via LinkedIn

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #7490 into master will increase coverage by 0.03%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7490      +/-   ##
==========================================
+ Coverage   27.16%   27.20%   +0.03%     
==========================================
  Files        1163     1164       +1     
  Lines       15518    15517       -1     
  Branches     2410     2410              
==========================================
+ Hits         4216     4221       +5     
+ Misses       9534     9528       -6     
  Partials     1768     1768              
Flag Coverage Δ
#front 19.36% <63.63%> (+0.04%) ⬆️
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/src/components/LeftMenu/LeftMenuFooter/index.js 33.33% <0.00%> (-33.34%) ⬇️
...rc/containers/EditViewDataManagerProvider/index.js 0.00% <0.00%> (ø)
.../admin/src/components/ComponentIconPicker/index.js 0.00% <0.00%> (ø)
...agerProvider/utils/retrieveComponentsFromSchema.js 68.75% <ø> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <ø> (ø)
...ovider/utils/getFieldsActionMatchingPermissions.js 100.00% <100.00%> (ø)
...ditViewDataManagerProvider/utils/tests/testData.js 100.00% <100.00%> (ø)
...rc/containers/InputModalStepperProvider/reducer.js 68.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ef1d4...4e85077. Read the comment docs.

@lauriejim
Copy link
Contributor

Hello @abolkog !

Thank you for this integration.

Can you please add the documentation related to the settings of this provider.
Here is the page where you have to add the documentation.
To do so, you will have to update the docs/v3.x/plugins/users-permissions.md file.
For the format, please, follow the same as the other provider.

Thank you.

@abolkog
Copy link
Contributor Author

abolkog commented Aug 18, 2020

Hey @lauriejim I have added the documentation.

@abolkog
Copy link
Contributor Author

abolkog commented Aug 24, 2020

hey @lauriejim any chance we can get this PR reviewed 😅

@derrickmehaffy
Copy link
Member

Hi @abolkog let me poke @petersg83

Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ! Thank you for your contribution, I just tried it and it works well :)
I've noticed a few typos, can you fix them please? Then we're good to merge!
Also if you can rebase your branch on master so there are no conflicts it would be perfect. Thanks!

docs/v3.x/plugins/users-permissions.md Outdated Show resolved Hide resolved
docs/v3.x/plugins/users-permissions.md Outdated Show resolved Hide resolved
@petersg83 petersg83 added this to the 3.1.5 milestone Sep 3, 2020
@petersg83 petersg83 added source: plugin:users-permissions Source is plugin/users-permissions package issue: enhancement Issue suggesting an enhancement to an existing feature labels Sep 3, 2020
@abolkog
Copy link
Contributor Author

abolkog commented Sep 4, 2020

Thanks @petersg83 for the review. I have fixed the typos and rebased to master.

@petersg83
Copy link
Contributor

petersg83 commented Sep 4, 2020

Hi ! Thanks :) It seems you have an unexpected file in your PR : packages/strapi-plugin-users-permissions/admin/src/components/PopUpForm/index.js
Can you fix that please? :)

Signed-off-by: Khalid Elshafie <abolkog@gmail.com>
Signed-off-by: Khalid Elshafie <abolkog@gmail.com>
Signed-off-by: Khalid Elshafie <abolkog@gmail.com>
@abolkog
Copy link
Contributor Author

abolkog commented Sep 4, 2020

@petersg83 removed the additional file

Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for your contribution ! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: plugin:users-permissions Source is plugin/users-permissions package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants