New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LinkedIn auth provider #7490
Add LinkedIn auth provider #7490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7490 +/- ##
==========================================
+ Coverage 27.16% 27.20% +0.03%
==========================================
Files 1163 1164 +1
Lines 15518 15517 -1
Branches 2410 2410
==========================================
+ Hits 4216 4221 +5
+ Misses 9534 9528 -6
Partials 1768 1768
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hello @abolkog ! Thank you for this integration. Can you please add the documentation related to the settings of this provider. Thank you. |
Hey @lauriejim I have added the documentation. |
hey @lauriejim any chance we can get this PR reviewed 😅 |
Hi @abolkog let me poke @petersg83 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi ! Thank you for your contribution, I just tried it and it works well :)
I've noticed a few typos, can you fix them please? Then we're good to merge!
Also if you can rebase your branch on master so there are no conflicts it would be perfect. Thanks!
Thanks @petersg83 for the review. I have fixed the typos and rebased to master. |
Hi ! Thanks :) It seems you have an unexpected file in your PR : |
Signed-off-by: Khalid Elshafie <abolkog@gmail.com>
Signed-off-by: Khalid Elshafie <abolkog@gmail.com>
Signed-off-by: Khalid Elshafie <abolkog@gmail.com>
@petersg83 removed the additional file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for your contribution ! :D
* Add LinkedIn auth provider Signed-off-by: Khalid Elshafie <abolkog@gmail.com> Signed-off-by: Garrett Fritz <garrettfritz@garretts-mbp.home>
Description of what you did:
Added LinkedIn auth provider to support login via LinkedIn