Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils::sanitize-entity tests #7497

Merged
merged 4 commits into from Aug 18, 2020
Merged

Conversation

Convly
Copy link
Member

@Convly Convly commented Aug 17, 2020

Add tests for sanitize-entity.
Rise coverage to 100% and handle edge cases;

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
@Convly Convly added the source: core:strapi Source is core/strapi package label Aug 17, 2020
@Convly Convly requested a review from petersg83 August 17, 2020 06:41
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #7497 into master will increase coverage by 0.16%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7497      +/-   ##
==========================================
+ Coverage   26.21%   26.38%   +0.16%     
==========================================
  Files        1131     1131              
  Lines       15440    15442       +2     
  Branches     2438     2439       +1     
==========================================
+ Hits         4048     4074      +26     
+ Misses       9576     9559      -17     
+ Partials     1816     1809       -7     
Flag Coverage Δ
#front 18.25% <ø> (ø)
#unit 53.85% <75.00%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi/lib/core-api/controller.js 23.07% <0.00%> (ø)
packages/strapi-utils/lib/sanitize-entity.js 100.00% <100.00%> (+38.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b39709a...6dff656. Read the comment docs.

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few questions

Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
@Convly Convly requested a review from petersg83 August 18, 2020 13:19
Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants