New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utils::sanitize-entity tests #7497
Conversation
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
Codecov Report
@@ Coverage Diff @@
## master #7497 +/- ##
==========================================
+ Coverage 26.21% 26.38% +0.16%
==========================================
Files 1131 1131
Lines 15440 15442 +2
Branches 2438 2439 +1
==========================================
+ Hits 4048 4074 +26
+ Misses 9576 9559 -17
+ Partials 1816 1809 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
8cd0745
to
762cc3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a few questions
…i into core/sanitize-entity-tests
Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Add tests for sanitize-entity.
Rise coverage to 100% and handle edge cases;