Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "no permission to see this field" #7517

Closed
wants to merge 1 commit into from

Conversation

petersg83
Copy link
Contributor

fix #7232

When a user has several roles, the permissions need to be merged.
I merged the fields attributes.

@HichamELBSI Should we worry about the merge of the conditions ? The merge strategy should be an intersection of all conditions.

Signed-off-by: Pierre Noël <petersg83@gmail.com>
@petersg83 petersg83 added issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: core:content-manager Source is core/content-manager package labels Aug 19, 2020
@petersg83 petersg83 added this to the 3.1.5 milestone Aug 19, 2020
@petersg83 petersg83 changed the title Fix "not permission to see this field" Fix "no permission to see this field" Aug 19, 2020
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #7517 into master will increase coverage by 0.15%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7517      +/-   ##
==========================================
+ Coverage   26.21%   26.37%   +0.15%     
==========================================
  Files        1131     1131              
  Lines       15440    15448       +8     
  Branches     2438     2442       +4     
==========================================
+ Hits         4048     4074      +26     
+ Misses       9576     9562      -14     
+ Partials     1816     1812       -4     
Flag Coverage Δ
#front 18.24% <0.00%> (-0.01%) ⬇️
#unit 53.85% <75.00%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/containers/EditViewDataManagerProvider/index.js 0.00% <0.00%> (ø)
packages/strapi/lib/core-api/controller.js 23.07% <0.00%> (ø)
packages/strapi-utils/lib/sanitize-entity.js 100.00% <100.00%> (+38.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e67421...0933159. Read the comment docs.

@soupette
Copy link
Contributor

@petersg83 I think this fix should be made in the back-end instead of the front-end. The back-end should send only one permission for a specific action instead of multiple ones as your fix works for the CM only and not for the plugins. I am closing this PR feel free to reopen it if you think I am making a wrong assumption.

@soupette soupette closed this Aug 25, 2020
@lauriejim lauriejim deleted the fix/7232/permissionReadFields branch August 26, 2020 09:36
@alexandrebodin alexandrebodin removed this from the 3.1.5 milestone Sep 16, 2020
@alexandrebodin alexandrebodin removed severity: medium If it breaks the basic use of the product but can be worked around source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relation field shows "No permission to view this field" for super-admin
3 participants