Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix strapi-plugin-content-type-builder #7521

Merged
merged 3 commits into from Sep 3, 2020

Conversation

MoreBlood
Copy link
Contributor

~ fixed ReferenceError: Cannot access 'allComponents' before initialization

~ fixed ReferenceError: Cannot access 'allComponents' before initialization
~ fixed cannot access 'originalIcon' before initialization
 strapi-plugin-content-type-builder fix
@MoreBlood MoreBlood changed the title Update retrieveComponentsFromSchema.js JS fundamentals fixes [strapi-plugin-content-type-builder] Aug 21, 2020
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #7521 into master will increase coverage by 0.16%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7521      +/-   ##
==========================================
+ Coverage   26.21%   26.38%   +0.16%     
==========================================
  Files        1131     1131              
  Lines       15440    15442       +2     
  Branches     2438     2439       +1     
==========================================
+ Hits         4048     4074      +26     
+ Misses       9576     9559      -17     
+ Partials     1816     1809       -7     
Flag Coverage Δ
#front 18.25% <0.00%> (ø)
#unit 53.85% <75.00%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../admin/src/components/ComponentIconPicker/index.js 0.00% <0.00%> (ø)
...agerProvider/utils/retrieveComponentsFromSchema.js 68.75% <ø> (ø)
packages/strapi/lib/core-api/controller.js 23.07% <0.00%> (ø)
packages/strapi-utils/lib/sanitize-entity.js 100.00% <100.00%> (+38.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e67421...1b2dc9a. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for your contribution

@soupette soupette added source: core:content-type-builder Source is core/content-type-builder package issue: bug Issue reporting a bug labels Sep 2, 2020
@alexandrebodin alexandrebodin added this to the 3.1.5 milestone Sep 3, 2020
@alexandrebodin alexandrebodin changed the title JS fundamentals fixes [strapi-plugin-content-type-builder] fix strapi-plugin-content-type-builder Sep 3, 2020
@alexandrebodin alexandrebodin merged commit b6a0c1b into strapi:master Sep 3, 2020
gfritzdev pushed a commit to gfritzdev/strapi that referenced this pull request Sep 7, 2020
* Update retrieveComponentsFromSchema.js

~ fixed ReferenceError: Cannot access 'allComponents' before initialization

* strapi-plugin-content-type-builder fix

~ fixed cannot access 'originalIcon' before initialization

Signed-off-by: Garrett Fritz <garrettfritz@garretts-mbp.home>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-type-builder Source is core/content-type-builder package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants