Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decimal on content manager's inputs #7527

Merged
merged 2 commits into from Aug 27, 2020
Merged

Fix decimal on content manager's inputs #7527

merged 2 commits into from Aug 27, 2020

Conversation

HichamELBSI
Copy link
Contributor

@HichamELBSI HichamELBSI commented Aug 19, 2020

Signed-off-by: HichamELBSI elabbassih@gmail.com

Description of what you did:

fixes #7401

@HichamELBSI HichamELBSI linked an issue Aug 19, 2020 that may be closed by this pull request
@Un1xG0d
Copy link

Un1xG0d commented Aug 19, 2020

I actually tried that solution late last night when I was having my issue, and that did not solve it for me. If I'm not mistaken, that var only controls the up and down arrows on the text field. So it was incrementing the number correctly, but I could not save the record due to some sort of validation telling me I needed to round to the nearest .1 still.

@HichamELBSI
Copy link
Contributor Author

Hello @psycoder17, I just try this one on Firefox and it works well for me. What version of Firefox do you have?

@HichamELBSI
Copy link
Contributor Author

@psycoder17 There is no additional validation. This is the native HTML form validator.


Capture d’écran 2020-08-21 à 14 28 44

soupette
soupette previously approved these changes Aug 25, 2020
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: HichamELBSI <elabbassih@gmail.com>
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #7527 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7527   +/-   ##
=======================================
  Coverage   26.37%   26.37%           
=======================================
  Files        1131     1131           
  Lines       15449    15449           
  Branches     2441     2441           
=======================================
  Hits         4074     4074           
  Misses       9564     9564           
  Partials     1811     1811           
Flag Coverage Δ
#front 18.24% <0.00%> (ø)
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntent-manager/admin/src/components/Inputs/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d281c...8bf691c. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add two decimals on number collection type
3 participants