Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize plugins translation in Traditional Chinese. #7557

Merged
merged 5 commits into from Sep 14, 2020
Merged

Optimize plugins translation in Traditional Chinese. #7557

merged 5 commits into from Sep 14, 2020

Conversation

Dominic0512
Copy link
Contributor

Description of what you did:

1.Optimize plugin 'content-type-builder' translations in zh.json.
2.Optimize plugin 'documentation' translations in zh.json.
3.Optimize plugin 'upload' translations in zh.json and filter button
missing translation wording.

Signed-off-by: Dominic Lee <dominiclee0512@gmail.com>
Signed-off-by: Dominic Lee <dominiclee0512@gmail.com>
missing translation wording.

Signed-off-by: Dominic Lee <dominiclee0512@gmail.com>
@Dominic0512 Dominic0512 reopened this Aug 22, 2020
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #7557 into master will increase coverage by 0.03%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7557      +/-   ##
==========================================
+ Coverage   27.16%   27.20%   +0.03%     
==========================================
  Files        1163     1164       +1     
  Lines       15518    15519       +1     
  Branches     2410     2412       +2     
==========================================
+ Hits         4216     4222       +6     
+ Misses       9534     9528       -6     
- Partials     1768     1769       +1     
Flag Coverage Δ
#front 19.36% <62.50%> (+0.04%) ⬆️
#unit 53.85% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...admin/admin/src/components/ContainerFluid/index.js 66.66% <ø> (ø)
...in/src/components/LeftMenu/LeftMenuFooter/index.js 33.33% <0.00%> (-33.34%) ⬇️
...rc/containers/EditViewDataManagerProvider/index.js 0.00% <0.00%> (ø)
.../admin/src/components/ComponentIconPicker/index.js 0.00% <0.00%> (ø)
...agerProvider/utils/retrieveComponentsFromSchema.js 68.75% <ø> (ø)
...ugin-upload/admin/src/components/EditForm/index.js 0.00% <0.00%> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <ø> (ø)
packages/strapi-provider-upload-local/lib/index.js 29.16% <0.00%> (ø)
...ovider/utils/getFieldsActionMatchingPermissions.js 100.00% <100.00%> (ø)
...ditViewDataManagerProvider/utils/tests/testData.js 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9296b...d143ebe. Read the comment docs.

@Dominic0512
Copy link
Contributor Author

Dominic0512 commented Aug 30, 2020

Is there any suggestions for the MR?

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added the issue: enhancement Issue suggesting an enhancement to an existing feature label Sep 14, 2020
@alexandrebodin alexandrebodin added this to the 3.1.5 milestone Sep 14, 2020
@alexandrebodin alexandrebodin merged commit bbb8b42 into strapi:master Sep 14, 2020
@alexandrebodin alexandrebodin added source: core:admin Source is core/admin package and removed issue: enhancement Issue suggesting an enhancement to an existing feature labels Sep 15, 2020
"attribute.password": "密碼",
"attribute.password.description": "加密過得密碼欄位",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dominic0512
"attribute.password.description": "加密過得密碼欄位"
It should be "的" instead of "得".
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants