Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM bug fixes #7589

Merged
merged 4 commits into from Aug 26, 2020
Merged

CM bug fixes #7589

merged 4 commits into from Aug 26, 2020

Conversation

soupette
Copy link
Contributor

Description of what you did:

This PR fixes #7455

Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette added source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Aug 25, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #7589 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7589   +/-   ##
=======================================
  Coverage   26.37%   26.37%           
=======================================
  Files        1131     1131           
  Lines       15449    15449           
  Branches     2441     2441           
=======================================
  Hits         4074     4074           
  Misses       9564     9564           
  Partials     1811     1811           
Flag Coverage Δ
#front 18.24% <0.00%> (ø)
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...anager/admin/src/components/SelectWrapper/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2957ad5...051ee9b. Read the comment docs.

Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark select input as not editable has no effect on update existed entity
2 participants