Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent from uninstalling the upload plugin in the admin panel #7590

Merged
merged 1 commit into from Aug 25, 2020

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril.lpz@gmail.com

Description of what you did:

This PR fixes #7572 by preventing users from uninstalling the upload plugin from the administration panel.

Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette added source: core:upload Source is core/upload package issue: bug Issue reporting a bug labels Aug 25, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #7590 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7590   +/-   ##
=======================================
  Coverage   26.38%   26.38%           
=======================================
  Files        1131     1131           
  Lines       15442    15442           
  Branches     2439     2439           
=======================================
  Hits         4074     4074           
  Misses       9559     9559           
  Partials     1809     1809           
Flag Coverage Δ
#front 18.25% <ø> (ø)
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee79e2...1b157c3. Read the comment docs.

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:upload Source is core/upload package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When deleting media library plugin: "Error: Command failed: npm run strapi -- uninstall upload -d"
2 participants