Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix front-end small issues #7597

Merged
merged 2 commits into from Aug 26, 2020
Merged

Fix front-end small issues #7597

merged 2 commits into from Aug 26, 2020

Conversation

soupette
Copy link
Contributor

Description of what you did:

This PR fixes some small issues in order to clean up the GitHub repo a bit.

Signed-off-by: soupette <cyril.lpz@gmail.com>
This fix is temporary until we develop the menu API

Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette added source: core:admin Source is core/admin package source: core:content-type-builder Source is core/content-type-builder package issue: bug Issue reporting a bug labels Aug 25, 2020
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #7597 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7597      +/-   ##
==========================================
- Coverage   26.38%   26.37%   -0.02%     
==========================================
  Files        1131     1131              
  Lines       15442    15449       +7     
  Branches     2439     2441       +2     
==========================================
  Hits         4074     4074              
- Misses       9559     9564       +5     
- Partials     1809     1811       +2     
Flag Coverage Δ
#front 18.24% <0.00%> (-0.02%) ⬇️
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trapi-admin/admin/src/containers/HomePage/index.js 9.09% <0.00%> (-1.26%) ⬇️
...lder/admin/src/components/CreatableSelect/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6589f6...a58442d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-type-builder Source is core/content-type-builder package
Projects
None yet
3 participants