Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/async pwd validation #7612

Merged
merged 3 commits into from Sep 1, 2020
Merged

Feat/async pwd validation #7612

merged 3 commits into from Sep 1, 2020

Conversation

VinitSarvade
Copy link
Contributor

@VinitSarvade VinitSarvade commented Aug 26, 2020

Description of what you did:

Use bcrypt.compare instead of bcrypt.compareSync to validate use password in user-permissions plugin.

#7261

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #7612 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7612   +/-   ##
=======================================
  Coverage   26.37%   26.37%           
=======================================
  Files        1131     1131           
  Lines       15449    15449           
  Branches     2441     2441           
=======================================
  Hits         4074     4074           
  Misses       9564     9564           
  Partials     1811     1811           
Flag Coverage Δ
#front 18.24% <ø> (ø)
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d281c...d1235ca. Read the comment docs.

@alexandrebodin alexandrebodin added source: plugin:users-permissions Source is plugin/users-permissions package issue: enhancement Issue suggesting an enhancement to an existing feature labels Sep 1, 2020
@alexandrebodin alexandrebodin added this to the 3.1.5 milestone Sep 1, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: plugin:users-permissions Source is plugin/users-permissions package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants