Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge permission for route GET /users/me/permissions #7613

Closed
wants to merge 1 commit into from

Conversation

petersg83
Copy link
Contributor

fix #7232

@petersg83 petersg83 requested a review from Convly August 26, 2020 12:25
@petersg83 petersg83 added this to the 3.1.5 milestone Aug 26, 2020
@petersg83 petersg83 added source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Aug 26, 2020
Signed-off-by: Pierre Noël <petersg83@gmail.com>
@petersg83 petersg83 force-pushed the fix/7232/permissionReadFields branch from e5b5da1 to 3fafa06 Compare August 26, 2020 13:15
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #7613 into master will increase coverage by 0.09%.
The diff coverage is 71.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7613      +/-   ##
==========================================
+ Coverage   26.37%   26.46%   +0.09%     
==========================================
  Files        1131     1131              
  Lines       15449    15481      +32     
  Branches     2441     2447       +6     
==========================================
+ Hits         4074     4097      +23     
- Misses       9564     9572       +8     
- Partials     1811     1812       +1     
Flag Coverage Δ
#front 18.24% <ø> (ø)
#unit 54.01% <71.87%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-admin/services/permission.js 86.08% <71.87%> (-5.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d281c...3fafa06. Read the comment docs.

@petersg83
Copy link
Contributor Author

Closing in favor of a field merge in the front

@petersg83 petersg83 closed this Sep 2, 2020
@lauriejim lauriejim deleted the fix/7232/permissionReadFields branch September 7, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relation field shows "No permission to view this field" for super-admin
1 participant