Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup http server in Strapi constructor #7672

Merged
merged 1 commit into from Sep 2, 2020
Merged

Conversation

alexandrebodin
Copy link
Member

Signed-off-by: Alexandre Bodin bodin.alex@gmail.com

Description of what you did:

Fix #7561

Signed-off-by: Alexandre Bodin <bodin.alex@gmail.com>
@alexandrebodin alexandrebodin added issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package labels Sep 1, 2020
@alexandrebodin alexandrebodin added this to the 3.1.5 milestone Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #7672 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7672   +/-   ##
=======================================
  Coverage   27.23%   27.23%           
=======================================
  Files        1163     1163           
  Lines       15532    15532           
  Branches     2411     2411           
=======================================
  Hits         4230     4230           
  Misses       9534     9534           
  Partials     1768     1768           
Flag Coverage Δ
#front 19.41% <ø> (ø)
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77be3ea...3bd10d6. Read the comment docs.

Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strapi exits on fs.writeFile()
2 participants