Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file info mutation #7691

Merged
merged 4 commits into from Sep 3, 2020
Merged

Update file info mutation #7691

merged 4 commits into from Sep 3, 2020

Conversation

Cr0s4k
Copy link
Contributor

@Cr0s4k Cr0s4k commented Sep 2, 2020

Description of what you did:

Adds a new mutation that allows to update file information (name, alternative text and caption). Fixes #7406

@Cr0s4k Cr0s4k marked this pull request as draft September 2, 2020 08:02
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #7691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7691   +/-   ##
=======================================
  Coverage   27.16%   27.16%           
=======================================
  Files        1163     1163           
  Lines       15518    15518           
  Branches     2410     2410           
=======================================
  Hits         4216     4216           
  Misses       9534     9534           
  Partials     1768     1768           
Flag Coverage Δ
#front 19.32% <ø> (ø)
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4987c1d...9fbe0c5. Read the comment docs.

@Cr0s4k Cr0s4k marked this pull request as ready for review September 2, 2020 09:44
@@ -5,6 +5,7 @@ module.exports = {
mutation: `
upload(refId: ID, ref: String, field: String, source: String, file: Upload!): UploadFile!
multipleUpload(refId: ID, ref: String, field: String, source: String, files: [Upload]!): [UploadFile]!
updateFileInfo(id: ID!, name: String, alternativeText: String, caption: String): UploadFile!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create a fileInfo input type :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

Signed-off-by: Omar Garcia <omarcruz11@hotmail.com>
Signed-off-by: Omar Garcia <omarcruz11@hotmail.com>
Signed-off-by: Omar Garcia <omarcruz11@hotmail.com>
Signed-off-by: Omar Garcia <omarcruz11@hotmail.com>
@alexandrebodin alexandrebodin added this to the 3.1.5 milestone Sep 3, 2020
@alexandrebodin alexandrebodin added source: plugin:graphql Source is plugin/graphql package issue: enhancement Issue suggesting an enhancement to an existing feature labels Sep 3, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: plugin:graphql Source is plugin/graphql package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UploadFile (Image) information, like alternativeText
2 participants