Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Strapi edition to the admin footer #7704

Merged
merged 3 commits into from Sep 3, 2020
Merged

Add Strapi edition to the admin footer #7704

merged 3 commits into from Sep 3, 2020

Conversation

remidej
Copy link
Contributor

@remidej remidej commented Sep 2, 2020

Signed-off-by: Rémi de Juvigny remi@hey.com

Description of what you did:

I changed the text on the bottom of the admin sidebar. The goal was to let the user know whether he's using community edition or enteprise edition.

It looks like this:

Screenshot 2020-09-02 at 17 01 08

Signed-off-by: Rémi de Juvigny <remi@hey.com>
@soupette
Copy link
Contributor

soupette commented Sep 2, 2020

@maevalienard can you check that the design is ok?

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #7704 into master will decrease coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7704      +/-   ##
==========================================
- Coverage   27.23%   27.16%   -0.08%     
==========================================
  Files        1163     1163              
  Lines       15532    15518      -14     
  Branches     2411     2410       -1     
==========================================
- Hits         4230     4215      -15     
- Misses       9534     9535       +1     
  Partials     1768     1768              
Flag Coverage Δ
#front 19.31% <50.00%> (-0.11%) ⬇️
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/src/components/LeftMenu/LeftMenuFooter/index.js 33.33% <0.00%> (-33.34%) ⬇️
...admin/admin/src/containers/LocaleToggle/Wrapper.js 100.00% <ø> (ø)
...i-admin/admin/src/containers/LocaleToggle/index.js 100.00% <ø> (ø)
...kages/strapi-admin/admin/src/translations/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6905be6...b191c36. Read the comment docs.

@maevalienard
Copy link

@remi2j @soupette Would you mind adding a "—" between the version and the name of the plan please? :)

Signed-off-by: Rémi de Juvigny <remi@hey.com>
@remidej
Copy link
Contributor Author

remidej commented Sep 2, 2020

@maevalienard after all this talk I managed to forget something 🙃

Here is an updated screenshot:

Screenshot 2020-09-02 at 18 00 31

I made the dash symbol part of the link. Otherwise it was the only white character of the line, which made it stand out in a weird way. Let me know if that's okay

@maevalienard
Copy link

LGTM thank you Rémi!

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants