Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Admin bugs #7716

Merged
merged 2 commits into from Sep 24, 2020
Merged

Fixes Admin bugs #7716

merged 2 commits into from Sep 24, 2020

Conversation

soupette
Copy link
Contributor

@soupette soupette commented Sep 3, 2020

Signed-off-by: soupette cyril.lpz@gmail.com

Description of what you did:

This PR fixes #7699 in particular point 2 and 4 of the issue.
Regarding point 1 about the prompt when clicking on an external link this cannot be achieved using react-router.
A workaround could be to use an html <a> tag with `target="_blank" so modifications are not lost when testing a link.

Signed-off-by: soupette <cyril.lpz@gmail.com>
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #7716 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7716      +/-   ##
==========================================
- Coverage   27.16%   27.15%   -0.02%     
==========================================
  Files        1163     1163              
  Lines       15518    15521       +3     
  Branches     2410     2411       +1     
==========================================
- Hits         4216     4215       -1     
- Misses       9534     9537       +3     
- Partials     1768     1769       +1     
Flag Coverage Δ
#front 19.30% <0.00%> (-0.02%) ⬇️
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/containers/AuthPage/components/Register/index.js 0.00% <ø> (ø)
...trapi-admin/admin/src/containers/AuthPage/index.js 0.00% <0.00%> (ø)
...admin/admin/src/containers/AuthPage/utils/forms.js 0.00% <ø> (ø)
...-manager/admin/src/components/CustomTable/index.js 0.00% <ø> (ø)
...rc/containers/EditViewDataManagerProvider/index.js 0.00% <0.00%> (ø)
...iners/HomePage/HomePageContent/HomePageSettings.js 0.00% <ø> (ø)
...in/src/components/LeftMenu/LeftMenuFooter/index.js 33.33% <0.00%> (-33.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4987c1d...84ac0f7. Read the comment docs.

Signed-off-by: soupette <cyril.lpz@gmail.com>
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strapi 3.14 + MongoDB + GraphQL - Creating With Repeatable Component
2 participants