Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace babel-jest with @swc-node/jest to speedup frontend testing #7724

Merged
merged 2 commits into from Sep 14, 2020

Conversation

Brooooooklyn
Copy link
Contributor

babel-jest

Test Suites: 168 passed, 168 total
Tests:       719 passed, 719 total
Snapshots:   8 passed, 8 total
Time:        65.408 s
Ran all test suites.

@swc-node/jest

Test Suites: 168 passed, 168 total
Tests:       719 passed, 719 total
Snapshots:   8 passed, 8 total
Time:        37.314 s
Ran all test suites.

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #7724 into master will increase coverage by 5.54%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7724      +/-   ##
==========================================
+ Coverage   27.16%   32.71%   +5.54%     
==========================================
  Files        1163     1194      +31     
  Lines       15518    12965    -2553     
  Branches     2410     1279    -1131     
==========================================
+ Hits         4216     4241      +25     
+ Misses       9534     7884    -1650     
+ Partials     1768      840     -928     
Flag Coverage Δ
#front 24.81% <70.00%> (+5.49%) ⬆️
#unit 53.85% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...admin/admin/src/components/ContainerFluid/index.js 75.00% <ø> (+8.33%) ⬆️
...in/src/components/LeftMenu/LeftMenuFooter/index.js 80.00% <0.00%> (+13.33%) ⬆️
...rc/containers/EditViewDataManagerProvider/index.js 0.00% <ø> (ø)
...tainers/EditViewDataManagerProvider/utils/index.js 0.00% <0.00%> (ø)
.../admin/src/components/ComponentIconPicker/index.js 0.00% <ø> (ø)
...agerProvider/utils/retrieveComponentsFromSchema.js 87.50% <ø> (+18.75%) ⬆️
...ugin-upload/admin/src/components/EditForm/index.js 0.00% <ø> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <0.00%> (ø)
packages/strapi-provider-upload-local/lib/index.js 29.16% <0.00%> (ø)
...ovider/utils/getFieldsActionMatchingPermissions.js 100.00% <100.00%> (ø)
... and 1078 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9296b...b75ab73. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow it seems way faster!

Thanks a lot for your contribution/

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However it prints some errors in the terminal about the coverage.
Can you check?

@Brooooooklyn
Copy link
Contributor Author

However it prints some errors in the terminal about the coverage.

Can you check?

Seems like I forgot to enable dynamicImport in config, I will fix it soon

@Brooooooklyn
Copy link
Contributor Author

@soupette fixed

Signed-off-by: LongYinan <longyinan.brooklyn@bytedance.com>
@Brooooooklyn
Copy link
Contributor Author

@soupette

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants