Fix replace media #7787
Merged
Fix replace media #7787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soupette
added
source: core:upload
soupette
requested review from
HichamELBSI and
petersg83
and removed request for
alexandrebodin
Codecov Report
@@ Coverage Diff @@
## master #7787 +/- ##
==========================================
+ Coverage 27.16% 27.20% +0.03%
==========================================
Files 1163 1164 +1
Lines 15518 15519 +1
Branches 2410 2412 +2
==========================================
+ Hits 4216 4222 +6
+ Misses 9534 9528 -6
- Partials 1768 1769 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petersg83
suggested changes
Sep 8, 2020
|
|
||
| const createFileToDownloadName = ({ file, fileInfo: { name } }) => { | ||
| const ext = get(file, 'ext', ''); | ||
|
|
||
| return `${name.replace(ext, '')}${ext}`; |
There was a problem hiding this comment.
In case the extension is also present in the name (ex: my.txtfile.txt), I think this line would not do what expected.
What about:
return name.endsWith(ext)
? name
: `${name}${ext}`;
Signed-off-by: soupette <cyril.lpz@gmail.com>
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: soupette cyril.lpz@gmail.com
Description of what you did:
This PR fixes #7776