Docs/integrations #7792
Docs/integrations #7792
Conversation
… docs/integrations
Signed-off-by: Maxime Castres <mcastres@student.42.fr>
…into docs/integrations
…into docs/integrations
Mcastres
requested review from
soupette,
alexandrebodin,
derrickmehaffy and
lauriejim
Codecov Report
@@ Coverage Diff @@
## documentation #7792 +/- ##
=================================================
+ Coverage 19.14% 27.16% +8.02%
=================================================
Files 855 1163 +308
Lines 11933 15518 +3585
Branches 1898 2410 +512
=================================================
+ Hits 2284 4215 +1931
- Misses 8100 9535 +1435
- Partials 1549 1768 +219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@Mcastres first off, holy cow, second nice job. Give me a few days to review ;) |
| `./src/App.svelte` | ||
|
|
||
| ```js | ||
| <script> |
There was a problem hiding this comment.
Same here about the example. Why don't we have it for the other apps?
There was a problem hiding this comment.
Difficult to reproduce on specific tech I'm not comfortable with
There was a problem hiding this comment.
Would love to help here also but I'm not familiar with svelte either
|
Can you please review this when you have time @lauriejim @alexandrebodin |
|
Hey everyone! It would be great to merge this if there is no more change requests here @lauriejim @derrickmehaffy |
|
I'll take another look today or tmrw |
|
@Mcastres Need approval from one of the tech team to be sure it has been reviewed and approved on the tech side. |
|
Is it good for you? @soupette |
No it is not I have requested changes that have been put in resolved but I strongly believe that they should be added, especially the ones where the doc states to install dependencies globally. |
|
I resolved it because I made the modifications. You can check it out in the Ruby file @soupette |
There was a problem hiding this comment.
Generaly speaking it is ok. plz apply the comments in the rest of the PR I just didn't copy/paste everywhere.
The fact that multiple examples are not consistent in terms of features is worrying me as you are going to get a lot more questions @derrickmehaffy @lauriejim. I think we should release a bunch of the most known ones that are really consistent and pass specific PRs for the rest of them to get help by community contributors that will be able to complete Maxime's work.
|
Thanks @alexandrebodin for taking the time to review this PR! |
alexandrebodin
added
source: docs
Description of what you did:
Added integrations for: