New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validation of Date and Time field types for Mongoose connector #5777 #7801
Conversation
9b4c0fd
to
5654dc9
Compare
Signed-off-by: richardgrey <richie.grey@gmail.com>
5654dc9
to
ef10fd1
Compare
Guys, not sure about the coding style. Kindly let me know if it needs to be changed. |
Codecov Report
@@ Coverage Diff @@
## master #7801 +/- ##
==========================================
+ Coverage 27.16% 27.20% +0.03%
==========================================
Files 1163 1164 +1
Lines 15518 15517 -1
Branches 2410 2410
==========================================
+ Hits 4216 4221 +5
+ Misses 9534 9528 -6
Partials 1768 1768
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Is there anyone who can confirm this PR? |
And also we should handle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thansk for this fix 💯
…trapi#7801) Signed-off-by: richardgrey <richie.grey@gmail.com>
Signed-off-by: richardgrey richie.grey@gmail.com
Description of what you did:
This PR fixes #5777
This changes will allow setting an empty value (null, undefined) for fields of type Date/Time through the API.
In the admin panel, it's still not possible to clear the value of Date or Time fields. It is on buffet/core DatePicker component and has related feature request to be able to clear the value of such inputs.