New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autocomplete issue in Chrome. Fixes #7666 #7802
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7802 +/- ##
==========================================
+ Coverage 27.16% 27.20% +0.03%
==========================================
Files 1163 1164 +1
Lines 15518 15519 +1
Branches 2410 2412 +2
==========================================
+ Hits 4216 4222 +6
+ Misses 9534 9528 -6
- Partials 1768 1769 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: richardgrey <richie.grey@gmail.com>
271fda0
to
bc0706a
Compare
I've updated the branch for the latest master, so merging is unblocked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for your contribution
Signed-off-by: richardgrey richie.grey@gmail.com
Description of what you did:
This PR fixes #7666
The fix is a simple setting
autocomplete
attribute tonew-password
. Forusername
setting this attribute tono
telling the browser that this field should be autocompleted as a field called "no". Basically, using unique value switching off the autocomplete.