Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocomplete issue in Chrome. Fixes #7666 #7802

Merged
merged 1 commit into from Sep 15, 2020

Conversation

richardgrey
Copy link
Contributor

Signed-off-by: richardgrey richie.grey@gmail.com

Description of what you did:

This PR fixes #7666

The fix is a simple setting autocomplete attribute to new-password. For username setting this attribute to no telling the browser that this field should be autocompleted as a field called "no". Basically, using unique value switching off the autocomplete.

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #7802 into master will increase coverage by 0.03%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7802      +/-   ##
==========================================
+ Coverage   27.16%   27.20%   +0.03%     
==========================================
  Files        1163     1164       +1     
  Lines       15518    15519       +1     
  Branches     2410     2412       +2     
==========================================
+ Hits         4216     4222       +6     
+ Misses       9534     9528       -6     
- Partials     1768     1769       +1     
Flag Coverage Δ
#front 19.36% <62.50%> (+0.04%) ⬆️
#unit 53.85% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...admin/admin/src/components/ContainerFluid/index.js 66.66% <ø> (ø)
...in/src/components/LeftMenu/LeftMenuFooter/index.js 33.33% <0.00%> (-33.34%) ⬇️
...min/admin/src/containers/ProfilePage/utils/form.js 100.00% <ø> (ø)
.../admin/src/containers/Users/EditPage/utils/form.js 100.00% <ø> (ø)
...rc/containers/EditViewDataManagerProvider/index.js 0.00% <0.00%> (ø)
.../admin/src/components/ComponentIconPicker/index.js 0.00% <0.00%> (ø)
...agerProvider/utils/retrieveComponentsFromSchema.js 68.75% <ø> (ø)
...ugin-upload/admin/src/components/EditForm/index.js 0.00% <0.00%> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <ø> (ø)
packages/strapi-provider-upload-local/lib/index.js 29.16% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9296b...bc0706a. Read the comment docs.

soupette
soupette previously approved these changes Sep 10, 2020
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: richardgrey <richie.grey@gmail.com>
@richardgrey
Copy link
Contributor Author

I've updated the branch for the latest master, so merging is unblocked.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autofill overwrites fields when editing users.
3 participants