Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to include MySQL docker-compose.yaml #7892

Merged
merged 1 commit into from Sep 15, 2020

Conversation

adamrhunter
Copy link
Contributor

Description of what you did:

Adds a MySQL tab to the list of docker-compose yaml files in the "Installation using Docker" section of the docs.

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #7892 into documentation will increase coverage by 8.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           documentation    #7892      +/-   ##
=================================================
+ Coverage          19.14%   27.16%   +8.02%     
=================================================
  Files                855     1163     +308     
  Lines              11933    15518    +3585     
  Branches            1898     2410     +512     
=================================================
+ Hits                2284     4215    +1931     
- Misses              8100     9535    +1435     
- Partials            1549     1768     +219     
Flag Coverage Δ
#front 19.31% <ø> (+4.82%) ⬆️
#unit 53.85% <ø> (+13.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...api-plugin-users-permissions/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...i-admin/admin/src/containers/SettingsPage/index.js 0.00% <0.00%> (-66.67%) ⬇️
...trapi-admin/admin/src/containers/LeftMenu/index.js 5.00% <0.00%> (-61.67%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
...in/admin/src/containers/Webhooks/ListView/index.js 0.00% <0.00%> (-42.11%) ⬇️
...in/admin/src/containers/Webhooks/EditView/index.js 0.00% <0.00%> (-38.40%) ⬇️
packages/strapi/lib/services/metrics/index.js 65.00% <0.00%> (-35.00%) ⬇️
...admin/admin/src/components/ContainerFluid/index.js 66.66% <0.00%> (-33.34%) ⬇️
... and 746 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 899e2eb...6d398c6. Read the comment docs.

@derrickmehaffy
Copy link
Member

You have tested this option right? Curious to know if it works even with the changes to the MySQL password auth. Also could you also include one for MariaDB as well (it's a drop in replacement for MySQL that is entirely open source)

@adamrhunter
Copy link
Contributor Author

You have tested this option right? Curious to know if it works even with the changes to the MySQL password auth. Also could you also include one for MariaDB as well (it's a drop in replacement for MySQL that is entirely open source)

@derrickmehaffy - Yes, indeed. It has been tested; I'm using this configuration for my local docker testing. Ok, yeah, we can create an example config for MariaDB

@derrickmehaffy
Copy link
Member

You have tested this option right? Curious to know if it works even with the changes to the MySQL password auth. Also could you also include one for MariaDB as well (it's a drop in replacement for MySQL that is entirely open source)

@derrickmehaffy - Yes, indeed. It has been tested; I'm using this configuration for my local docker testing. Ok, yeah, we can create an example config for MariaDB

Awesome, glad to hear it, I know on a normal MySQL install you have to manually specify mysql_native_password 👍

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending a review from @alexandrebodin just to confirm

Signed-off-by: Adam Hunter <arhunter@gmail.com>
@adamrhunter
Copy link
Contributor Author

You have tested this option right? Curious to know if it works even with the changes to the MySQL password auth. Also could you also include one for MariaDB as well (it's a drop in replacement for MySQL that is entirely open source)

@derrickmehaffy - Yes, indeed. It has been tested; I'm using this configuration for my local docker testing. Ok, yeah, we can create an example config for MariaDB

Awesome, glad to hear it, I know on a normal MySQL install you have to manually specify mysql_native_password 👍

@derrickmehaffy - Ok, I've added MariaDB yml example to the commit. I also bumped the MySQL docker version to latest (8 at time of writing) and forced the legacy authentication plugin via the command param. I tested (fresh install and create content via admin ui) both on my local docker server.

@derrickmehaffy
Copy link
Member

@adamrhunter Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants