New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to include MySQL docker-compose.yaml #7892
Conversation
9168fb9
to
76086d7
Compare
Codecov Report
@@ Coverage Diff @@
## documentation #7892 +/- ##
=================================================
+ Coverage 19.14% 27.16% +8.02%
=================================================
Files 855 1163 +308
Lines 11933 15518 +3585
Branches 1898 2410 +512
=================================================
+ Hits 2284 4215 +1931
- Misses 8100 9535 +1435
- Partials 1549 1768 +219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
You have tested this option right? Curious to know if it works even with the changes to the MySQL password auth. Also could you also include one for MariaDB as well (it's a drop in replacement for MySQL that is entirely open source) |
@derrickmehaffy - Yes, indeed. It has been tested; I'm using this configuration for my local docker testing. Ok, yeah, we can create an example config for MariaDB |
Awesome, glad to hear it, I know on a normal MySQL install you have to manually specify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending a review from @alexandrebodin just to confirm
Signed-off-by: Adam Hunter <arhunter@gmail.com>
fdec579
to
6d398c6
Compare
@derrickmehaffy - Ok, I've added MariaDB yml example to the commit. I also bumped the MySQL docker version to latest (8 at time of writing) and forced the legacy authentication plugin via the command param. I tested (fresh install and create content via admin ui) both on my local docker server. |
@adamrhunter Awesome, thank you! |
Description of what you did:
Adds a MySQL tab to the list of docker-compose yaml files in the "Installation using Docker" section of the docs.