Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Models Page Grammar #7912

Merged
merged 5 commits into from Sep 23, 2020
Merged

Updated Models Page Grammar #7912

merged 5 commits into from Sep 23, 2020

Conversation

cwray-tech
Copy link
Contributor

Description of what you did:

Quickly went through the models' page in the documentation and updated some grammar as well as added some emphasis and brief clarification in a couple of places.

Quickly went through the models' page in the documentation and updated some grammar as well as added some emphasis and brief clarification in a couple of places.
@cwray-tech
Copy link
Contributor Author

Hey, Just noticed that I missed removing a word on one of the lines that will look pretty bad:
remove it

@derrickmehaffy
Copy link
Member

@cwray-tech you can update your local branch and it will reflect here automatically, no need to resubmit a pull request ;)

@cwray-tech
Copy link
Contributor Author

cwray-tech commented Sep 15, 2020

@derrickmehaffy This shows you how unfamiliar I am with this! Will do, I thought later, maybe that is talking about a singular Strapi Model global id? If so, I could change it back to the way it was before.

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #7912 into documentation will increase coverage by 8.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           documentation    #7912      +/-   ##
=================================================
+ Coverage          19.14%   27.16%   +8.02%     
=================================================
  Files                855     1163     +308     
  Lines              11933    15518    +3585     
  Branches            1898     2410     +512     
=================================================
+ Hits                2284     4215    +1931     
- Misses              8100     9535    +1435     
- Partials            1549     1768     +219     
Flag Coverage Δ
#front 19.31% <ø> (+4.82%) ⬆️
#unit 53.85% <ø> (+13.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-plugin-email/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...api-plugin-users-permissions/admin/src/pluginId.js 0.00% <0.00%> (-100.00%) ⬇️
...n/src/containers/NotificationProvider/constants.js 0.00% <0.00%> (-100.00%) ⬇️
...i-admin/admin/src/containers/SettingsPage/index.js 0.00% <0.00%> (-66.67%) ⬇️
...trapi-admin/admin/src/containers/LeftMenu/index.js 5.00% <0.00%> (-61.67%) ⬇️
...n/admin/src/containers/LanguageProvider/reducer.js 0.00% <0.00%> (-61.54%) ⬇️
...in/admin/src/containers/Webhooks/ListView/index.js 0.00% <0.00%> (-42.11%) ⬇️
...in/admin/src/containers/Webhooks/EditView/index.js 0.00% <0.00%> (-38.40%) ⬇️
packages/strapi/lib/services/metrics/index.js 65.00% <0.00%> (-35.00%) ⬇️
...admin/admin/src/components/ContainerFluid/index.js 66.66% <0.00%> (-33.34%) ⬇️
... and 746 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca0743...2d806bf. Read the comment docs.

Quickly went through the models' page in the documentation and updated some grammar as well as added some emphasis and brief clarification in a couple of places.

Signed-off-by: Christopher Wray <53663762+cwray-tech@users.noreply.github.com>
Signed-off-by: Christopher Wray <53663762+cwray-tech@users.noreply.github.com>
@cwray-tech
Copy link
Contributor Author

@derrickmehaffy is there anything I need to do to merge this? Thank you!

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants