Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noindex to public index page #7917

Merged
merged 2 commits into from Oct 1, 2020
Merged

Add noindex to public index page #7917

merged 2 commits into from Oct 1, 2020

Conversation

votemike
Copy link
Contributor

Description of what you did:

Added noindex to index page as it is rare that such a page would want to be indexed.

Signed-off-by: Michael Gwynne <michael.gwynne@checkatrade.com>
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #7917 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7917   +/-   ##
=======================================
  Coverage   32.71%   32.71%           
=======================================
  Files        1194     1194           
  Lines       12965    12965           
  Branches     1279     1279           
=======================================
  Hits         4241     4241           
  Misses       7884     7884           
  Partials      840      840           
Flag Coverage Δ
#front 24.81% <ø> (ø)
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...min/admin/src/containers/ProfilePage/utils/form.js 100.00% <ø> (ø)
.../admin/src/containers/Users/EditPage/utils/form.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf1f4f9...4d1e09b. Read the comment docs.

@alexandrebodin
Copy link
Member

Can you also add the nofollow directive ;)

Signed-off-by: Michael Gwynne <michael.gwynne@checkatrade.com>
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants