Encode the URL before fetching it. #7934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: François de Metz <francois@2metz.fr>
francois2metz
force-pushed
the
encode-proxied-url
branch
from
4c97571
to
d530d36
Compare
Codecov Report
@@ Coverage Diff @@
## master #7934 +/- ##
=======================================
Coverage 32.71% 32.71%
=======================================
Files 1194 1194
Lines 12965 12965
Branches 1279 1279
=======================================
Hits 4241 4241
Misses 7884 7884
Partials 840 840
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alexandrebodin
added
source: core:upload
|
Thanks for this PR 👍 |
derappelt
pushed a commit
to derappelt/strapi
that referenced
this pull request
Sep 23, 2020
Signed-off-by: François de Metz <francois@2metz.fr>
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the URL we were fetching via the proxy had utf-8 characters, the proxy returned a 500 "Request path contains unescaped characters".
Before fetching the URL, we now encode it.
I added a few tests (the utf-8 characters one is failing on master, as expected). I used strapi.io as the proxied url, not really happy about it as it relies on an external service. If you have a better idea, tell me.