Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deleteFile graphql mutation (#5292). #7937

Merged
merged 3 commits into from Oct 5, 2020

Conversation

francois2metz
Copy link
Contributor

This fix #5292 by implementing and testing the removeFile mutation.

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #7937 into master will decrease coverage by 0.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7937      +/-   ##
==========================================
- Coverage   32.96%   32.95%   -0.02%     
==========================================
  Files        1197     1197              
  Lines       13020    13027       +7     
  Branches     1286     1286              
==========================================
+ Hits         4292     4293       +1     
- Misses       7885     7891       +6     
  Partials      843      843              
Flag Coverage Δ
#front 25.05% <14.28%> (-0.01%) ⬇️
#unit 53.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in-content-manager/admin/src/translations/index.js 0.00% <0.00%> (ø)
...ntent-type-builder/admin/src/translations/index.js 0.00% <0.00%> (ø)
...ugin-documentation/admin/src/translations/index.js 0.00% <0.00%> (ø)
...trapi-plugin-email/admin/src/translations/index.js 0.00% <0.00%> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <0.00%> (ø)
...-users-permissions/admin/src/translations/index.js 0.00% <0.00%> (ø)
...kages/strapi-admin/admin/src/translations/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e015f...88fd2a9. Read the comment docs.

@alexandrebodin
Copy link
Member

Hi @francois2metz just a small update before we can merge ;)

@francois2metz
Copy link
Contributor Author

@alexandrebodin I'll try to do it today. Thanks for the reminder ;).

@francois2metz francois2metz force-pushed the delete-files-graphql branch 2 times, most recently from e521ea5 to 21dde85 Compare September 29, 2020 14:48
Signed-off-by: François de Metz <francois@2metz.fr>
Signed-off-by: François de Metz <francois@2metz.fr>
Signed-off-by: François de Metz <francois@2metz.fr>
@francois2metz
Copy link
Contributor Author

I updated the PR to check if the file exists, and added a commit to fix a typo. I can remove it from this branch if you don't want to mix the history.

@alexandrebodin alexandrebodin added source: core:upload Source is core/upload package issue: enhancement Issue suggesting an enhancement to an existing feature labels Oct 5, 2020
@alexandrebodin alexandrebodin added this to the 3.2.0 milestone Oct 5, 2020
@alexandrebodin
Copy link
Member

Thansk for this PR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: feature request Issue suggesting a new feature source: core:upload Source is core/upload package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL removing files
2 participants