Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up minimum required Node to 10.16 #7962

Merged
merged 1 commit into from Sep 22, 2020

Conversation

peteretelej
Copy link
Contributor

Description of what you did:

Updated README docs & package.json engine versions to bump up the minimum required Node version for strapi from 10.10 to 10.16 (or 10.16.0+)

Strapi no longer supports node 10.10: Since it updated sharp to 0.26.0 ( #7729 ), it now requires Node 10.16.0+
(See https://github.com/lovell/sharp/blob/master/docs/changelog.md#v0260---25th-august-2020 )

yarn create strapi-app my-project --quickstart when run on Node 10.10 fails with error

error sharp@0.26.0: The engine "node" is incompatible with this module. Expected version ">=10.16.0". Got "10.10.0"
error Found incompatible module.

Updated README docs & package.json `engine` versions to bump up the
minimum required Node version from `10.10` to `10.16` (or `10.16.0+`)

Strapi no longer supports `10.10` since it updated `sharp` to `0.26.0`
( strapi#7729 ) which requires Node 10.16.0+
(See https://github.com/lovell/sharp/blob/master/docs/changelog.md#v0260---25th-august-2020 )

` yarn create strapi-app my-project --quickstart` on 10.10 fails with error
```
error sharp@0.26.0: The engine "node" is incompatible with this module. Expected version ">=10.16.0". Got "10.10.0"
error Found incompatible module.
```

Signed-off-by: Peter Etelej <peter@etelej.com>
@codecov
Copy link

codecov bot commented Sep 20, 2020

Codecov Report

Merging #7962 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7962   +/-   ##
=======================================
  Coverage   32.71%   32.71%           
=======================================
  Files        1194     1194           
  Lines       12965    12965           
  Branches     1279     1279           
=======================================
  Hits         4241     4241           
  Misses       7884     7884           
  Partials      840      840           
Flag Coverage Δ
#front 24.81% <ø> (ø)
#unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...min/admin/src/containers/ProfilePage/utils/form.js 100.00% <ø> (ø)
.../admin/src/containers/Users/EditPage/utils/form.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ce464...57262ef. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update !

@alexandrebodin alexandrebodin merged commit 318f20e into strapi:master Sep 22, 2020
@alexandrebodin alexandrebodin added this to the 3.2.0 milestone Sep 22, 2020
@alexandrebodin alexandrebodin added source: core:strapi Source is core/strapi package issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes and removed source: core:strapi Source is core/strapi package labels Sep 22, 2020
@peteretelej peteretelej deleted the fix/min-node branch September 22, 2020 15:31
derappelt pushed a commit to derappelt/strapi that referenced this pull request Sep 23, 2020
Updated README docs & package.json `engine` versions to bump up the
minimum required Node version from `10.10` to `10.16` (or `10.16.0+`)

Strapi no longer supports `10.10` since it updated `sharp` to `0.26.0`
( strapi#7729 ) which requires Node 10.16.0+
(See https://github.com/lovell/sharp/blob/master/docs/changelog.md#v0260---25th-august-2020 )

` yarn create strapi-app my-project --quickstart` on 10.10 fails with error
```
error sharp@0.26.0: The engine "node" is incompatible with this module. Expected version ">=10.16.0". Got "10.10.0"
error Found incompatible module.
```

Signed-off-by: Peter Etelej <peter@etelej.com>
@cawoodm
Copy link

cawoodm commented Jan 21, 2021

Is there an overview of which node versions a particular strapi version (e.g. 3.1.6) supports? We'd like to use Node14.

@alexandrebodin
Copy link
Member

Hi @cawoodm you can verify which version of node we support by running a command like this npm info strapi@3.x.x engines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants