Fix/warn file too big #8033
Merged
Fix/warn file too big #8033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersg83
force-pushed
the
fix/warnFileTooBig
branch
from
98f0294
to
9286bb2
Compare
Codecov Report
@@ Coverage Diff @@
## master #8033 +/- ##
==========================================
+ Coverage 32.71% 32.72% +0.01%
==========================================
Files 1194 1196 +2
Lines 12969 13007 +38
Branches 1280 1285 +5
==========================================
+ Hits 4243 4257 +14
- Misses 7886 7905 +19
- Partials 840 845 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
petersg83
force-pushed
the
fix/warnFileTooBig
branch
from
9286bb2
to
878a8bf
Compare
alexandrebodin
requested changes
Sep 28, 2020
alexandrebodin
requested changes
Sep 28, 2020
| @@ -0,0 +1,8 @@ | |||
| const errorTypes = { | |||
There was a problem hiding this comment.
I would move that to the errors file and only expose the errors interface
Signed-off-by: soupette <cyril.lpz@gmail.com>
|
@petersg83 seems like the linter is happy now. |
alexandrebodin
approved these changes
Sep 29, 2020
alexandrebodin
added
issue: bug
hdeadman
pushed a commit
to hdeadman/strapi
that referenced
this pull request
Sep 29, 2020
* handle fileTooBig errors Signed-off-by: Pierre Noël <petersg83@gmail.com> * add entityTooLarge error in provider plugins Signed-off-by: Pierre Noël <petersg83@gmail.com> * fix linter Signed-off-by: Pierre Noël <petersg83@gmail.com> * refacto Signed-off-by: Pierre Noël <petersg83@gmail.com> * Add better error message for 413 errors in ML Signed-off-by: soupette <cyril.lpz@gmail.com> * refacto Signed-off-by: Pierre Noël <petersg83@gmail.com> * refacto Signed-off-by: Pierre Noël <petersg83@gmail.com> Co-authored-by: soupette <cyril.lpz@gmail.com>
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No modification where made for the providers
awsandrackspaceas they accept files up to 5 Go and the node buffer limit is 2 Go. So I couldn't test files bigger than 5 Go + the error would throw before the provider says it's too large.It will be needed once we have change the buffers for streams.
@soupette @HichamELBSI I tag you because I updated the front part: the linter was not happy. Can you check everything's fine please?