Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow browser options while using watch-admin #8054

Merged
merged 1 commit into from Sep 29, 2020

Conversation

erictsangx
Copy link
Contributor

strapi develop --watch-admin   //open the default browser
strapi develop --watch-admin --browser false   //do not open any browser
strapi develop --watch-admin --browser 'google chrome' //open Google Chrome
strapi develop --watch-admin --browser Firefox //open Firefox

@erictsangx erictsangx closed this Sep 25, 2020
Signed-off-by: erictsangx <erictsangx@gmail.com>
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #8054 into master will increase coverage by 0.00%.
The diff coverage is 64.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8054   +/-   ##
=======================================
  Coverage   32.71%   32.71%           
=======================================
  Files        1194     1194           
  Lines       12965    12970    +5     
  Branches     1279     1280    +1     
=======================================
+ Hits         4241     4243    +2     
- Misses       7884     7887    +3     
  Partials      840      840           
Flag Coverage Δ
#front 24.80% <0.00%> (-0.01%) ⬇️
#unit 53.88% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/containers/AuthPage/components/Register/index.js 0.00% <ø> (ø)
...trapi-admin/admin/src/containers/AuthPage/index.js 0.00% <0.00%> (ø)
...admin/admin/src/containers/AuthPage/utils/forms.js 0.00% <ø> (ø)
...min/admin/src/containers/ProfilePage/utils/form.js 100.00% <ø> (ø)
.../admin/src/containers/Users/EditPage/utils/form.js 100.00% <ø> (ø)
...-manager/admin/src/components/CustomTable/index.js 0.00% <ø> (ø)
...rc/containers/EditViewDataManagerProvider/index.js 0.00% <0.00%> (ø)
...ugin-upload/admin/src/components/EditForm/index.js 0.00% <0.00%> (ø)
...iners/HomePage/HomePageContent/HomePageSettings.js 0.00% <ø> (ø)
packages/strapi-utils/lib/index.js 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9abb4...04b189e. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have tested and it works correctly! Thanks a lot for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants