Assume selection is text when creating a link

[jlsjonas]

Fixes #7890

Description of what you did:

Title says it all, when replacing a selection, assume the selection is text and not a link; as per the issue

[codecov]

Codecov Report

Merging #8071 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8071      +/-   ##
==========================================
- Coverage   32.71%   32.71%   -0.01%     
==========================================
  Files        1194     1194              
  Lines       12969    12970       +1     
  Branches     1280     1280              
==========================================
  Hits         4243     4243              
- Misses       7886     7887       +1     
  Partials      840      840              

Flag	Coverage Δ
#front	24.80% <0.00%> (-0.01%)	⬇️
#unit	53.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-manager/admin/src/components/Wysiwyg/constants.js	0.00% <ø> (ø)
...nt-manager/admin/src/components/Wysiwyg/helpers.js	0.00% <ø> (ø)
...ugin-upload/admin/src/components/EditForm/index.js	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a21a11...24c31b4. Read the comment docs.

[sam-pires]

Hello @jlsjonas,
Thanks for the PR 👍

I still have the same behavior as the current one. It has not changed.
@soupette wdyt?

[soupette]

In order to make the selected change you'll also need to update Wysiwyg/constants.js file L.79 with the following:

{
  label: 'Link',
  style: 'LINK',
  className: 'link',
  hideLabel: true,
  handler: 'addContent',
  text: '[textToReplace](link)',
},

[soupette]

LGTM!

Thanks a lot for your contribution.

[jlsjonas]

@soupette You're welcome!
What do we do with the coverage report failing at -0% due to lack of testing in that area of the code?

[soupette]

@soupette You're welcome!
What do we do with the coverage report failing at -0% due to lack of testing in that area of the code?

Appart from adding some tests to this component not much. Even though the coverage doesn't pass we will still merge this PR.