Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per hook timeout config option #8081

Merged
merged 3 commits into from Sep 29, 2020
Merged

Per hook timeout config option #8081

merged 3 commits into from Sep 29, 2020

Conversation

MattieBelt
Copy link
Collaborator

Description of what you did:

Added a per hook timeout config option & updated the hook docs. Related to #8067.

@MattieBelt
Add per hook timeout config
92838c1 
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
@MattieBelt
Update hook docs with timeout config options
98b5548 
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
@codecov
Copy link

codecov bot commented Sep 28, 2020 •
edited

Codecov Report

Merging #8081 into master will increase coverage by 0.01%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8081      +/-   ##
==========================================
+ Coverage   32.71%   32.73%   +0.01%     
==========================================
  Files        1194     1196       +2     
  Lines       12969    13009      +40     
  Branches     1280     1285       +5     
==========================================
+ Hits         4243     4258      +15     
- Misses       7886     7906      +20     
- Partials      840      845       +5
Flag Coverage Δ
#front 24.80% <16.66%> (-0.01%) ⬇️
#unit 53.77% <41.17%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/src/containers/NotificationProvider/selectors.js 0.00% <0.00%> (ø)
...-manager/admin/src/components/Wysiwyg/constants.js 0.00% <ø> (ø)
...nt-manager/admin/src/components/Wysiwyg/helpers.js 0.00% <ø> (ø)
...cumentation/admin/src/containers/HomePage/index.js 0.00% <ø> (ø)
...ugin-upload/admin/src/components/EditForm/index.js 0.00% <0.00%> (ø)
.../containers/InputModalStepper/InputModalStepper.js 0.00% <ø> (ø)
.../src/containers/InputModalStepperProvider/index.js 0.00% <0.00%> (ø)
...-upload/admin/src/containers/ModalStepper/index.js 0.00% <ø> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <0.00%> (ø)
packages/strapi-plugin-upload/services/Upload.js 15.75% <0.00%> (-0.45%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4700f79...0334946. Read the comment docs.

alexandrebodin
alexandrebodin approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @derrickmehaffy can you validate the doc ?

@alexandrebodin alexandrebodin added source: core:strapi Source is core/strapi package issue: enhancement Issue suggesting an enhancement to an existing feature labels Sep 29, 2020
@alexandrebodin alexandrebodin added this to the 3.1.7 milestone Sep 29, 2020
derrickmehaffy
derrickmehaffy approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alexandrebodin alexandrebodin merged commit c527595 into strapi:master Sep 29, 2020
hdeadman pushed a commit to hdeadman/strapi that referenced this pull request Sep 29, 2020
@MattieBelt @hdeadman
Per hook timeout config option (strapi#8081)
0007d04 
* Add per hook timeout config

Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>

* Update hook docs with timeout config options

Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
@MattieBelt MattieBelt deleted the feature/per-hook-timeout branch October 1, 2020 22:01
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

@derrickmehaffy derrickmehaffy derrickmehaffy approved these changes

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:strapi Source is core/strapi package
Projects
None yet
Milestone
3.1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MattieBelt @alexandrebodin @derrickmehaffy