Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes missing error message when ses sendEmail returns an error #8086

Merged

Conversation

adamrhunter
Copy link
Contributor

Signed-off-by: Adam Hunter arhunter@gmail.com

Description of what you did:

Signed-off-by: Adam Hunter <arhunter@gmail.com>
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #8086 into master will increase coverage by 0.01%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8086      +/-   ##
==========================================
+ Coverage   32.71%   32.73%   +0.01%     
==========================================
  Files        1194     1196       +2     
  Lines       12969    13009      +40     
  Branches     1280     1285       +5     
==========================================
+ Hits         4243     4258      +15     
- Misses       7886     7906      +20     
- Partials      840      845       +5     
Flag Coverage Δ
#front 24.80% <16.66%> (-0.01%) ⬇️
#unit 53.77% <41.17%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/src/containers/NotificationProvider/selectors.js 0.00% <0.00%> (ø)
...-manager/admin/src/components/Wysiwyg/constants.js 0.00% <ø> (ø)
...nt-manager/admin/src/components/Wysiwyg/helpers.js 0.00% <ø> (ø)
...cumentation/admin/src/containers/HomePage/index.js 0.00% <ø> (ø)
...ugin-upload/admin/src/components/EditForm/index.js 0.00% <0.00%> (ø)
.../containers/InputModalStepper/InputModalStepper.js 0.00% <ø> (ø)
.../src/containers/InputModalStepperProvider/index.js 0.00% <0.00%> (ø)
...-upload/admin/src/containers/ModalStepper/index.js 0.00% <ø> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <0.00%> (ø)
packages/strapi-plugin-upload/services/Upload.js 15.75% <0.00%> (-0.45%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4700f79...2487869. Read the comment docs.

@alexandrebodin alexandrebodin self-requested a review October 7, 2020 12:37
@alexandrebodin alexandrebodin added source: core:email Source is core/email package issue: enhancement Issue suggesting an enhancement to an existing feature labels Oct 7, 2020
@alexandrebodin alexandrebodin added this to the 3.2.1 milestone Oct 7, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for this contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:email Source is core/email package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strapi-provider-email-amazon-ses returns error undefined when incorrect was credentials are used
2 participants