Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add private option field for relations #8149

Merged

Conversation

tanmoyopenroot
Copy link
Contributor

Fixes #6060

Checklist

  • Includes tests
  • Update documentation

Description of what you did:

This PR adds private option to the relation.

Screenshot 2020-10-02 at 1 06 32 PM

Signed-off-by: tanmoyopenroot <tanmoy.openroot@gmail.com>
Signed-off-by: tanmoyopenroot <tanmoy.openroot@gmail.com>
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #8149 into master will increase coverage by 0.24%.
The diff coverage is 47.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8149      +/-   ##
==========================================
+ Coverage   32.71%   32.95%   +0.24%     
==========================================
  Files        1194     1197       +3     
  Lines       12969    13019      +50     
  Branches     1280     1286       +6     
==========================================
+ Hits         4243     4291      +48     
+ Misses       7886     7885       -1     
- Partials      840      843       +3     
Flag Coverage Δ
#front 25.05% <16.66%> (+0.25%) ⬆️
#unit 53.88% <50.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/src/containers/NotificationProvider/selectors.js 0.00% <0.00%> (ø)
...-manager/admin/src/components/Wysiwyg/constants.js 0.00% <ø> (ø)
...nt-manager/admin/src/components/Wysiwyg/helpers.js 0.00% <ø> (ø)
...lder/admin/src/containers/FormModal/utils/forms.js 22.03% <ø> (+22.03%) ⬆️
...pi-plugin-content-type-builder/utils/attributes.js 30.00% <ø> (ø)
...cumentation/admin/src/containers/HomePage/index.js 0.00% <ø> (ø)
...ugin-upload/admin/src/components/EditForm/index.js 0.00% <0.00%> (ø)
.../containers/InputModalStepper/InputModalStepper.js 0.00% <ø> (ø)
.../src/containers/InputModalStepperProvider/index.js 0.00% <0.00%> (ø)
...-upload/admin/src/containers/ModalStepper/index.js 0.00% <ø> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbfde36...c038428. Read the comment docs.

Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, thank you for the contribution.

Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:content-type-builder Source is core/content-type-builder package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage private field option for relations
3 participants