-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email test in plugin settings #8156
Conversation
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
Move Test button Add testEmail input Update config fields Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
I would suggest renaming Also I'm curious if the default send/reply emails are actually used 🤔 |
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
That's indeed better @derrickmehaffy, see updated image.
It depends on the provider: strapi/packages/strapi-plugin-email/services/Email.js Lines 9 to 11 in 51b23d1
All the official provider use the |
Awesome :) I want the frontend team to just review to make sure they don't have any comments so this might not get merged til around monday but we will see. Other than that, I think this addition is awesome, thank you! |
Codecov Report
@@ Coverage Diff @@
## master #8156 +/- ##
==========================================
- Coverage 35.95% 35.88% -0.08%
==========================================
Files 1335 1342 +7
Lines 14726 14809 +83
Branches 1468 1476 +8
==========================================
+ Hits 5295 5314 +19
- Misses 8514 8576 +62
- Partials 917 919 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to add the permissions to the backend so they can be selected in the Admin panel :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @MattieBelt for your contribution!
Can you check the permissions defined can be managed in the permission view otherwise this new setting section will never be visible.
packages/strapi-plugin-email/admin/src/containers/Settings/index.js
Outdated
Show resolved
Hide resolved
packages/strapi-plugin-email/admin/src/containers/Settings/components.js
Outdated
Show resolved
Hide resolved
packages/strapi-plugin-email/admin/src/containers/Settings/index.js
Outdated
Show resolved
Hide resolved
packages/strapi-plugin-email/admin/src/containers/Settings/index.js
Outdated
Show resolved
Hide resolved
packages/strapi-plugin-email/admin/src/containers/Settings/index.js
Outdated
Show resolved
Hide resolved
packages/strapi-plugin-email/admin/src/containers/Settings/index.js
Outdated
Show resolved
Hide resolved
packages/strapi-plugin-email/admin/src/containers/Settings/index.js
Outdated
Show resolved
Hide resolved
@MattieBelt do you need any help for fixing the requested changes? |
Hey @soupette, no. Just didn't have any time yet. Plannend on looking into it this morning. Thanks for the feedback already! |
Hey @soupette,
|
Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
Yeah you should be fine here, since we aren't changing data in the database, we are just firing an action (say for example like a webhook) |
* Update mail text * Fix alignment * Add yup validation * Update form submission Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
Description of what you did:
Fixes #5935, by adding a email plugin section to the settings page.
The email settings section contains the current configuration (disabled) and a button to send a test mail.
EDIT: updated image:
Any feedback is welcome.