Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right padding if contains some right adornment for UID input #8174

Merged
merged 2 commits into from Oct 12, 2020

Conversation

tanmoyopenroot
Copy link
Contributor

Fix #5416

Checklist

  • Includes tests
  • Update documentation

Description of what you did:

Add right padding if input contains icon at the end.

right-padding: 40px + 1rem

Screenshot 2020-10-04 at 12 16 56 PM

Signed-off-by: tanmoyopenroot <tanmoy.openroot@gmail.com>
@tanmoyopenroot tanmoyopenroot changed the title fix(uid-input): add right padding if contains some right adornment Add right padding if contains some right adornment for UID input Oct 4, 2020
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #8174 into master will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8174      +/-   ##
==========================================
- Coverage   33.04%   32.95%   -0.10%     
==========================================
  Files        1219     1197      -22     
  Lines       13573    13028     -545     
  Branches     1348     1287      -61     
==========================================
- Hits         4485     4293     -192     
+ Misses       8206     7891     -315     
+ Partials      882      844      -38     
Flag Coverage Δ
#front 25.05% <0.00%> (+0.35%) ⬆️
#unit 53.88% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-manager/admin/src/components/InputUID/InputUID.js 0.00% <0.00%> (ø)
...ent-manager/admin/src/components/InputUID/index.js 0.00% <ø> (ø)
...ugin-content-type-builder/services/ContentTypes.js 21.12% <0.00%> (-11.44%) ⬇️
...kages/strapi-admin/validation/common-validators.js 79.16% <0.00%> (-10.12%) ⬇️
packages/strapi/lib/core-api/service.js 69.23% <0.00%> (-3.50%) ⬇️
...manager/services/utils/configuration/attributes.js 51.51% <0.00%> (-2.66%) ⬇️
...dmin/admin/src/components/Webhooks/Inputs/index.js 83.33% <0.00%> (-2.39%) ⬇️
...pi-plugin-content-type-builder/utils/attributes.js 30.00% <0.00%> (-2.00%) ⬇️
packages/strapi-admin/validation/permission.js 76.19% <0.00%> (-1.81%) ⬇️
packages/strapi-plugin-upload/services/Upload.js 15.75% <0.00%> (-0.81%) ⬇️
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3ff9d...3173904. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for your contribution!

@soupette soupette added source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last characters in long UID textfield are hidden
2 participants