Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-fetch to 2.6.1 #8191

Merged
merged 1 commit into from Oct 6, 2020
Merged

Conversation

wendorf
Copy link
Contributor

@wendorf wendorf commented Oct 5, 2020

node-fetch < 2.6.1 has a security vulnerability
(GHSA-w7rc-rwvf-8q5r)

This is a major version bump for strapi-plugin-upload (from 1.7.3), but
it does not look like strapi-plugin-upload is relying on any of the
functionality that has broken from 1.x to 2.x

This covers the same change in #7975, but for more than strapi-generate-new.

This also covers three dependabot PRs that were closed without merging:

Description of what you did:

Bumped node-fetch in the packages that use it, to address a security vulnerability.

  • strapi-generate-new: 1.7.3 -> 2.6.1
  • strapi-plugin-upload: 2.6.0 -> 2.6.1
  • strapi: 2.6.0 -> 2.6.1

alexandrebodin
alexandrebodin previously approved these changes Oct 5, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello as told in the previous PRs the vulnerable code is not used but I have been able to test so merging ;)

@wendorf
Copy link
Contributor Author

wendorf commented Oct 5, 2020

@alexandrebodin Thanks for moving forward with it! Even if it's not used, it causes security vulnerability scanners to flag it, so this will reduce headaches for people who see the false positive :)

node-fetch < 2.6.1 has a security vulnerability
(GHSA-w7rc-rwvf-8q5r)

This is a major version bump for strapi-plugin-upload (from 1.7.3), but
it does not look like strapi-plugin-upload is relying on any of the
functionality that has broken from 1.x to 2.x

Signed-off-by: Dan Wendorf <dan@render.com>
@wendorf
Copy link
Contributor Author

wendorf commented Oct 5, 2020

Whoops, sorry to clear the review, @alexandrebodin. I just force-pushed with a sign-off in the commit to make the DCO check pass.

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #8191 into master will decrease coverage by 0.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8191      +/-   ##
==========================================
- Coverage   32.96%   32.95%   -0.02%     
==========================================
  Files        1197     1197              
  Lines       13020    13027       +7     
  Branches     1286     1286              
==========================================
+ Hits         4292     4293       +1     
- Misses       7885     7891       +6     
  Partials      843      843              
Flag Coverage Δ
#front 25.05% <14.28%> (-0.01%) ⬇️
#unit 53.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in-content-manager/admin/src/translations/index.js 0.00% <0.00%> (ø)
...ntent-type-builder/admin/src/translations/index.js 0.00% <0.00%> (ø)
...ugin-documentation/admin/src/translations/index.js 0.00% <0.00%> (ø)
...trapi-plugin-email/admin/src/translations/index.js 0.00% <0.00%> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <0.00%> (ø)
...-users-permissions/admin/src/translations/index.js 0.00% <0.00%> (ø)
...kages/strapi-admin/admin/src/translations/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 645c0b8...6788a2c. Read the comment docs.

@alexandrebodin
Copy link
Member

Will wait for the tests to pass and merge ;)

@wendorf
Copy link
Contributor Author

wendorf commented Oct 5, 2020

@alexandrebodin Since this PR has no code changes, I don't think the code coverage failures are actionable. Is there anything I should do here?

@alexandrebodin alexandrebodin added issue: enhancement Issue suggesting an enhancement to an existing feature source: core:strapi Source is core/strapi package labels Oct 6, 2020
@alexandrebodin alexandrebodin modified the milestones: 3.2.0, 3.2.1 Oct 6, 2020
@alexandrebodin alexandrebodin merged commit bf8c17f into strapi:master Oct 6, 2020
@alexandrebodin
Copy link
Member

Thank you for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants